[DOC] Codebase walkthrough with vector add example #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Dec 17, 2018
docs/dev/codebase_walkthrough.rst
Outdated
| - Compile the operator into object code | ||
|
|
||
| One of the interesting aspects of TVM codebase is that interop between C++ and Python is not unidirectional. Typically, all code that do heavy liftings are implemented in C++, and Python bindings are provided for user interface. This is also true in TVM, but in TVM codebase, C++ code also call into functions defined in a Python module. For example, the convolution operator is implemented in Python, and its implementation is invoked from C++ code in nnvm. | ||
|
|
There was a problem hiding this comment.
Given that we are transitioning to relay, Is it possible to directly introduce the graph related part in the context of relay?
There was a problem hiding this comment.
Sure, I can update nnvm part with relay to reflect the latest development. But I think it is a good idea to leave some note about nnvm because many doc and tutorials are written in terms of nnvm. People may be confused If we don't mention nnvm in this doc.
|
I should mention that the vector add example in this PR use low level tvm API directly. There is no detail of topi, nnvm, or relay, to keep it simple. |
masahi
force-pushed
the
doc-codebase-walkthrough
branch
from
bca6fc8
to
c4aa149
Compare
|
If there is no further requested changes, I will merge this PR within 24 hours. Thanks @masahi @yzhliu @merrymercy @jroesch |
tqchen
approved these changes
Dec 20, 2018
zhiics
pushed a commit
to zhiics/tvm
that referenced
this pull request
Dec 21, 2018
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I screwed up my PR at #2206 and accidentally closed it, so reopening here. All comments I got there are addressed.
The first stab at #2160.
@tqchen @yzhliu @merrymercy @vinx13 please review.