[TOPI] bitserial_conv2d move to autotvm template and updates #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please request reviewers |
|
@eqy @ZihengJiang, please review |
eqy
reviewed
Mar 15, 2019
| policy='candidate', candidate=[ | ||
| [n, oh, ow, co, vh, vw, kh, kw, ci_o, kb, ib, vc, ci_i], | ||
| [n, oh, ow, co, vh, vw, kw, kh, ci_o, kb, ib, vc, ci_i],]) | ||
| cfg.add_flop(2 * N * OH * OW * CO * CI * 8 * KH * KW) |
There was a problem hiding this comment.
Does the automatic flop calculation in #2776 work for this?
There was a problem hiding this comment.
Sadly no :( it gives an error about multiple output in the compute.
| re_axes = cfg.define_reorder("reorder_0", | ||
| [n, oh, ow, co, vh, vw, kh, kw, kb, ib, vc, ci], | ||
| policy='interval_all', interval=(3, 7)) | ||
| cfg.add_flop(2 * N * OH * OW * CO * CI * 8 * KH * KW) |
| re_axes = cfg.define_reorder("reorder_0", | ||
| [n, co, oh, ow, vc, vh, vw, kh, kw, kb, ib, ci], | ||
| policy='interval_all', interval=(6, 11)) | ||
| cfg.add_flop(2 * N * OH * OW * CO * CI * 8 * KH * KW) |
| @@ -45,6 +44,9 @@ def test_bitserial_conv2d(): | |||
| verify_bitserial_conv2d_nhwc(1, in_size, ic, oc, k, stride, pad, 1, 1, False) | |||
| verify_bitserial_conv2d_nhwc(1, in_size, ic, oc, k, stride, pad, 2, 1, False) | |||
|
|
|||
| verify_bitserial_conv2d_nhwc(1, in_size, ic, oc, k, stride, pad, 1, 1, True) | |||
There was a problem hiding this comment.
Is it possible to add a correctness check here for random or precomputed inputs? It looks like generate_quantized_np is no longer used.
There was a problem hiding this comment.
Added, but it will only run on an arm device.
|
@ajtulloch @vinx13 please also help review the PR if you have time. @cowanmeg please try to rebase and fix the CI problem |
vinx13
requested changes
Mar 31, 2019
vinx13
approved these changes
Apr 3, 2019
tqchen
added
status: accepted
and removed
status: need review
status: need update
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 7, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 7, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 8, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 10, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to arm_cpu and x86 bitserial_conv2d operators