Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Frontend][TF] Add tensor array ops #3798

Merged
merged 12 commits into from Oct 18, 2019
Merged

Conversation

wweic
Copy link
Contributor

@wweic wweic commented Aug 17, 2019

Add a new type tensor_t in prelude that represents a tensor with variable rank. And tensor array is a list of tensor_t.

type tensor_t = 
| tensor0 of TensorType([])        
| tensor1 of TensorType([Any()])
| tensor2 of TensorType([Any(), Any()]) 
| tensor3 of TensorType([Any(), Any(), Any()])   
| tensor4 of TensorType([Any(), Any(), Any(), Any()])   
| tensor5 of TensorType([Any(), Any(), Any(), Any(), Any()])   
| tensor6 of TensorType([Any(), Any(), Any(), Any(), Any(), Any()])   

type tensor_array = list tensor_t

// build a tensor array with size n
let tensor_array n =
  match n with
| 0 -> nil()
| x -> cons(tensor_nil(), tensor_array(x-1))

// read nth element from ta
let tensor_array_read ta n = nth ta n

// write v to nth position of ta
let tensor_array_write ta n v = update ta n v

// concatenate two tensor_t
let tensor_concatenate a b =
  match (a,b) with 
  | tensor1(t1), tensor1(t2) -> tensor1(op.concat(t1, t2))
  | tensor2(t1), tensor2(t2) -> tensor2(op.concat(t1, t2))
  | tensor3(t1), tensor3(t2) -> tensor3(op.concat(t1, t2))
  | tensor4(t1), tensor4(t2) -> tensor4(op.concat(t1, t2))

// grow the tensor rank by 1
let tensor_add_one t =
  match t with
  | tensor0 of tt -> tensor1(expand_dims(tt))
  | tensor1 of tt -> tensor2(expand_dims(tt))
  | tensor2 of tt -> tensor3(expand_dims(tt))
  | tensor3 of tt -> tensor4(expand_dims(tt))
  | tensor4 of tt -> tensor5(expand_dims(tt))
  | tensor5 of tt -> tensor6(expand_dims(tt))

// return the values in tensor array as stacked tensor
let tensor_array_stack ta =
  let tensors_add_one = map(tensor_add_one, ta) in
  fodl(tensor_concatenate, hd(tensors_add_one), tl(tensors_add_one)))

// return tensor array size
let tensor_array_size ta = length ta

// (tensor_array -> TensorType([any()]) -> tensor_array -> tensor_array) 
let tensor_array_scatter ta indices values = 
  let helper ta current limit indices values = 
    if (current == limit) {
      ta
    } else {
      helper(tensor_array_write(ta, op.take(indices, current),tensor_array_read(values, current)),
                  current+1, limit, indices, values)
    }
  in
  let indices_shape = op.shape_of(indices) in
  let limit = op.take(indices_shape, 0) in
  helper(ta, 0, limit, indices, values)

let tensor_array_gather ta indices = 
  let helper ta accu current limit indices = 
    if (current == 0) {
      tensor_array_stack(accu)
    } else {
      helper(ta, cons(tensor_array_read(ta, op.take(indices, current-1)), accu), current-1, limit, indices)
    }
  in
  let indices_shape = op.shape_of(ta) in
  let limit = op.take(indices_shape, 0) in
  helper(ta, nil(), limit, limit, indices)

let tensor_array_split ta value lengths = 
  let helper ta1 value1 offset current1 limit1 lengths1  = 
    if (current1 == limit1) {
      ta1
    } else {
      tensor_array_write(helper(ta1, value1, offset1 + op.take(lengths1, current1), current1+1, limit1, lengths1), current1, tensor_take(value1, offset1, offset1 + op.take(lengths1, current1)))
    }
  in
  let lengths_shape = op.shape_of(lengths) in
  let lengths_limit = op.take(lengths_shape, 0) in
  helper(ta, value, 0, 0, lengths_limit, lengths)

let tensor_arrray_concat ta = 
  match ta with
  | nil() -> tensor_nil()
  | cons(hd, nil()) -> hd
  | cons(hd, cons as tl) -> tensor_concatenate(hd, tensor_array_concat(tl))

This PR depends on #3606.

Todo:

  • constructor
  • read
  • write
  • stack
  • unstack
  • size
  • scatter
  • gather
  • split
  • concat
  • more tests

@wweic wweic force-pushed the tensor-array-pr branch 3 times, most recently from 7c6b08b to 42f78bb Compare August 22, 2019 22:51
@wweic wweic force-pushed the tensor-array-pr branch 22 times, most recently from c3f80b8 to 3390745 Compare September 16, 2019 01:00
@wweic wweic marked this pull request as ready for review September 16, 2019 01:00
@wweic
Copy link
Contributor Author

wweic commented Sep 16, 2019

@icemelon9 @zhiics @jroesch @MarisaKirisame @kevinthesun @yongwww @srkreddy1238 Please take a look.

@icemelon
Copy link
Member

I wonder if we should define the prelude function in text format for better readability. Not sure whether the text parser is powerful enough.

tests/python/relay/test_adt.py Outdated Show resolved Hide resolved
tests/python/relay/test_adt.py Outdated Show resolved Hide resolved
tests/python/relay/test_adt.py Outdated Show resolved Hide resolved
tests/python/frontend/tensorflow/test_forward.py Outdated Show resolved Hide resolved
@wweic wweic requested a review from zhiics October 17, 2019 21:26
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wweic
Copy link
Contributor Author

wweic commented Oct 17, 2019

Jenkins is failing @tqchen FYI

@zhiics zhiics merged commit 36a9677 into apache:master Oct 18, 2019
@zhiics
Copy link
Member

zhiics commented Oct 18, 2019

Thanks everyone. This is now merged.

@wweic wweic deleted the tensor-array-pr branch October 18, 2019 05:47
petrex added a commit to petrex/tvm that referenced this pull request Oct 29, 2019
* master: (51 commits)
  [QNN][TFLite] Parsing QNN Add op. Adding MobilenetV2. (apache#4142)
  [CI] Pin NNPack pthreadtools version (apache#4152)
  Fix typo (apache#4144)
  [Relay][Frontend][TF] Add tensor array ops (apache#3798)
  [relay][vm] Separate VM runtime with executable (apache#4100)
  [PATCH] Fix undefined __floatdihf in libtvmruntime.so on aarch64. (apache#4119)
  [DOCKER] Pin torchvision==0.4.1 (apache#4140)
  [TOPI][x86] Cascade lake support. (apache#4123)
  [Relay] Improve build error when no lowered funcs are produced (apache#4132)
  [RUNTIME] Refactor object python FFI to new protocol. (apache#4128)
  Update PULL_REQUEST_TEMPLATE.md
  Adding support for dequantizing from int32 to float32. (apache#4130)
  [Relay][Training] Add and fix gradients (apache#4126)
  [QNN] Change default rouning to UPWARD. (apache#4131)
  Fix infer type of kernel in dense. (apache#4125)
  [Relay][AlterOpLayout] NHWC to NCHWc pad operator. (apache#4103)
  [ARITH] Fix lowering of floormod(x, y) != 0 (apache#4127)
  [RFC][RUNTIME] Introduce new object protocol. (apache#4115)
  [Relay][Topi] Disable conv NHWC pack int8. (apache#4038)
  Update task_cpp_unittest.sh
  ...
@apivovarov
Copy link
Contributor

apivovarov commented Oct 29, 2019

@zhiics @petrex @icemelon9 @tqchen This PR adds Prelude() to tensorflow.py frontend.
It means that Tensorflow frontend needs TVM to be built with ANTLR. Which needs Java.
Do we really want that dependency in Tensorflow frontend?
https://discuss.tvm.ai/t/relay-from-tensorflow-failed-couldnt-find-antlr-parser/4529

@apivovarov
Copy link
Contributor

apivovarov commented Oct 30, 2019

Another issue is that tvm/relay/grammar/py3 module is missing after the installation on Ubuntu 18
#4215

kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Oct 30, 2019
* [Relay][Frontend][TF] Add tensor array ops

* rename

* delete test

* Move utility function

* Refactor

* fix tensor array ops

* fix test

* fix rebase

* Fix serializer bug

* Improve tf convert name lookup to use prelude api

* Fix lint

* Fix test
@soiferj
Copy link
Contributor

soiferj commented Oct 31, 2019

@wweic is there an easy way to generate definitions for tensor arrays of size larger than 6? What’s the recommendation if we want to go up to, say, 100?

@wweic
Copy link
Contributor Author

wweic commented Oct 31, 2019

@soiferj you can generate tensor array of any size with the function tensor_array(n). I suppose you meant tensor with rank more than 6? If this is the case, we need to add a constructor with the higher rank. But I doubt if we need to manipulate tensors with large rank in real use cases. Do you have such requirement?

kevinthesun added a commit to neo-ai/tvm that referenced this pull request Oct 31, 2019
* [relay][vm] Separate VM runtime with executable (apache#4100)

* [relay][vm] Separate VM runtime with executable

* Address comments

* move ctx back to vm

* make only vm related fields and methods protected

* integrate seriliaztion/deserialization to executable

* create stream

* [Relay][Frontend][TF] Add tensor array ops (apache#3798)

* [Relay][Frontend][TF] Add tensor array ops

* rename

* delete test

* Move utility function

* Refactor

* fix tensor array ops

* fix test

* fix rebase

* Fix serializer bug

* Improve tf convert name lookup to use prelude api

* Fix lint

* Fix test

* Fix typo (apache#4144)

* [CI] Pin NNPack pthreadtools version (apache#4152)

* [QNN][TFLite] Parsing QNN Add op. Adding MobilenetV2. (apache#4142)

* Add lift_if_then_else pass (apache#3865)

* Add LiftIfThenElse pass

* Add more comments

* Rename and refactor

* Add description for internal data structure

* Rename a test

* Minor change

* Address comments

* Improve update_for

* [CI] Update cpu docker (apache#4153)

* [Refactor] Rename Datatype to ADT (apache#4156)

We think it will reduce the confusion with the meaning.

https://discuss.tvm.ai/t/discuss-consider-rename-vm-datatype/4339

* [Runtime] Enable option to use OpenMP thread pool (apache#4089)

* [REFACTOR][NODE][RUNTIME] Move Node to the new Object protocol. (apache#4161)

* [REFACTOR][NODE][RUNTIME] Move Node to the new Object protocol.

This PR removes the original node system, and make node as a subclass of Object.
This is a major refactor towards a better unified runtime object system.

List of changes in the refactor:

- We now hide data_ field, use Downcast explicitly to get a sub-class object.
- Removed the node system FFI in python.
- Removed the node C API, instead use PackedFunc for list and get attrs.
- Change relay::Op::set_attr_type_key(attr_key_name) to relay::Op::set_attr_type<AttrType>().
  - This change was necessary because of the new Object registration mechanism.
  - Subsequent changes to the op registrations
  - The change revealed a few previous problems that is now fixed.
- Patched up a few missing node type registration.
  - Now we will raise an error if we register object that is not registered.
- The original node.h and container.h are kept in the same location.
- Calling convention: kObjectHandle now equals the old kNodeHandle, kNodeHandle is removed.
- IRFunctor now dispatches on ObjectRef.
- Update to the new type checking API: is_type, derived_from are replaced by IsInstance.
- Removed .hash member function, instead use C++ convention hasher functors.

* Address review comments

* [CI] Move golang tests to the end (apache#4164)

* Add support for quantized multiply to Relay (apache#4141)

This patch adds multiply operator for quantized tensors.
The details of the quantized multiplication are outlined
in the code.

This builds on pull request 3927 and includes the changes
Animesh mentions in the comments on that request.

Change-Id: I555715b53d0266a91d5c03dc3dfe8fc31e7ce4e1

* Fix missspelling (apache#4166)

FIX "After connecting he usb" with "After connecting the usb"

* [Relay][Pass] Count MAC for BatchMatMul (apache#4157)

* count MAC for BatchMatMul

* update doc

* [Relay][QNN] Add unit test for int8 (apache#4159)

* [bugfix][codegen] fix casting bug in llvm codegen

* update example

* retrigger ci

* check llvm version

* [relay][vm] Reuse allocated device memory (apache#4170)

* add missing gradient check to gradient pass (apache#4169)

* merge extract_from_program and extract_from_multiple_progam (apache#4173)

* [TOPI] Added support for Mali Bifrost target (apache#4047)

* [Relay][Frontend][TF] Fix Size operator (apache#4175)

* [Relay][Frontend][TF] Fix Size operator

* Uncomment tests

* [Pass] Remove dead code (apache#4177)

* [rpc] use callback func to do send & recv (apache#4147)

* [rpc] use callback func to do send & recv. don't get fd from sock as it is deprecated in java

* fix java build

* fix min/max macro define in windows

* keep the old rpc setup for py

* add doc for CallbackChannel

* Add support and testing for tf.assert (as no-op) and tf.no_op to TF Relay frontend. (apache#4172)

* [DOCS] Add TensorFlow frontend docs (apache#4154)

* Start to update TF frontend docs

* Add rst

* Remove markdown

* Update wording

* Resolve comments

* Revert "[Relay][QNN] Add unit test for int8 (apache#4159)" (apache#4192)

This reverts commit 6f9d028.

* [cmake][ANTLR] Support setting path to ANTLR jar (apache#4176)

* Support setting path to ANTLR jar

* Update comment

* Split adaptive_pool2d_avg into sum and div (apache#4186)

* [Documentation]Fix example code in comment of tvm.build_module.build() (apache#4195)

* Fix example code in comment of tvm.build_module.build()

* Update build_module.py

* [relay] use time_evaluator for measurement (apache#4191)

* Add parser support for SUM tflite operator (apache#4182)

* [Relay] Fix memory leak in the interpreter (apache#4155)

* save

lint

* address reviewer comment

* [TOPI] Tunable Template for Conv2D HWCN on CUDA (apache#4168)

* support conv2d HWCN in AutoTVM and Relay

* fix lint

* fix comments and unit tests

* TensorCore Support using Intrinsic (apache#4136)

* add tensor core support

* avoid memory bank conflict

* fix thread sync & better performance

* better performance

* add schedule test for conv2d

* extend into BatchMatMul

* support config fragment shape and layout using intrinsic

* add TensorCore tutorial

* add int support and fix lint

* address comment

* add 32*16*8 TensorCore test

* fix wmma include logic

* [NODE][REFACTOR] Refactor reflection system in node. (apache#4189)

* [NODE][REFACTOR] Refactor reflection system in node.

- Removed the old Node, Node is now just an alias of runtime::Object
- Introduce ReflectionVTable, a new columnar dispatcher to support reflection
  - This allows us to remove vtable from most node objects
  - The VisitAttrs are registered via TVM_RESGITER_NODE_TYPE,
    they are no longer virtual.
- Consolidated serialization and reflection features into node.

* Explicit type qualification when calling destructor.

* Fix SPIRV, more comments

* hotfix the ci (apache#4199)

* [TOPI][x86] Legalize - Support int8xint8 convolution to use VNNI instructions. (apache#4196)

* [Relay] crossentropy_with_logits and its gradient (apache#4075)

* save

* lint

* [hotfix] missing include headers (apache#4204)

* [Relay][Training] Add checkpoint annotation for checkpointing memory optimization (apache#4146)

* add checkpoint annotation for checkpointing memory optimization

* add alpha-equivalence checkpoint test and fix gradient type issue

* fix build issues

* ignore checkpoint annotation when checking missing gradients

* refactor, fix checkpoint compute for tuple and add tests

* [Relay][Params] Add APIs for storing and retrieving parameters from individual functions. (apache#4194)

* Add support for attaching params

* Fix types

* Fix test

* [Relay][Frontend][ONNX] Add support for op Where (apache#4184)

* Add support for op Where

* Update impl version

* [VTA][Chisel] TSIM VTA Source Refactor (apache#4163)

* app init push

* fix on readme

* change name, add bit serial explanantion

* rm serialLoadMM, change doc

* syntax change for readme

* add parallel test functionality

* fix readme

* add python doc

* syntax

* init commit

* fix empty line

* fix typo

* [RUNTIME] Separate runtime related contrib into runtime/contrib (apache#4207)

* Fix type var docs (apache#4208)

* [Relay] Setting Legalize opt_level to 1. (apache#4198)

* [TOPI] Fix flaky testcase for check round (apache#4211)

* [Relay][Op] Enhance Upsample Operator to support float scales   (apache#4206)

* :add scale2 for upsample

* update unit test for upsampling

* support latest upsample op for multiple frontend

* fix lint

* fix lint

* fix lint

* fix lint

* update scale description and rebase

* [Relay][Quantize] Use fixed point mulplications (apache#4160)

* Update have_int8 condition to run on compute capability 7.x devices (apache#4214)

* Optimizing autotvm task extraction speed (apache#4138)

* Optimize task extraction speed

* correct pylint errors

* Delete unused function

* remove unnecessary argument

* resolve code review comments

* corrent cpp lint errors

* remove one more graph_json return value

* fix test bugs

* [Relay] Add Python type functor and tests (apache#4209)

* Add Python type functor and tests

* Lint roller

* Fix typo in packed_func.h (apache#4219)

* Improve the lowering of Qnn Dense (apache#4213)

* [QNN] Improving Dense lowering.

* - Moving get_shape method to util
- Finalizing the test cases and the code structure for optimized dense computation.

* - Fixing cpplint.

* - Addressing review comments.

* - Renaming the variables correctly.

* - Renaming the variables correctly.

* [ARITH] Fix the rule y < x && x <= y (apache#4220)

* [PYTHON] Add __init__ to the generated grammar so that it can be installed properly (apache#4223)

* [Relay][Frontend][ONNX] New Operators and Opsets to Support BERT (apache#4197)

* Added slice v10

* Added constantofshape operation and small refactor.

* Finished one_hot implementation.

* Reshape working across all bert layers.

* Fixed constantofshape and removed code duplication.

* onnx model fully ingested.

* Working on improving onnx tests.

* Changed onnx testing to use onnxruntime instead of caffe2, also formatted.

* Add arbitrary output nodes to onnx frontend.

* Added v6 tiling for bert squad 8 support.

* Small syntax fixes

* Reduced code duplication in split opset versions.

* Added batch matmul test

* Added unstack split testing.

* Adde onehot test, needs a little cleanup probably.

* Replaced deprecated constant fill with constantofshape and updated tests accordingly.

* Added tests for new opset version of slice and tile.

* lint clean up

* Lint fixes

* Changed onnx dependency

* Went back to caffe2 runtime for CI integration.

* Rebase and small typo/syntax changes.

* Added hard casting of onehot attributes to int.

* [Relay][Topi][TensorFlow][ONNX][Lang] Add support for Any op (apache#4205)

* Add support for Any op

* Support ONNX frontend

* Add doc

* Add to relay docs

* Dummy change to retrigger CI

*  Update dmlc_tvm_commit_id.txt

* Merge from upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants