Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreML] Solve CoreML frontend issue of image scaler and padding #3800

Merged
merged 1 commit into from Aug 19, 2019

Conversation

FrozenGene
Copy link
Member

@FrozenGene FrozenGene commented Aug 18, 2019

We have issue of image scaler and padding in CoreML frontend, so our mobilenet model has incorrect classify result. see issue #3725

Also update the tutorial of CoreML frontend, mobilenet model input image format is BGR.

@tqchen tqchen merged commit cb22d50 into apache:master Aug 19, 2019
@tqchen
Copy link
Member

tqchen commented Aug 19, 2019

Thanks @FrozenGene

@FrozenGene
Copy link
Member Author

I find the codebase of master branch's CI is red (http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/master/1459/pipeline) after merged, however, CI is green as seen when PR is made and I can not reproduce the issue. @tqchen Do we need to restart the CI?

@FrozenGene
Copy link
Member Author

FrozenGene commented Aug 19, 2019

After tried it about ~100 times, I reproduce it. It is one occasionally problem and seems only happened on CUDA (with Cython3 enabled). When we turn on opt_level=3, we call alter_op_layout pass and when we insert one pad with all zeros (i.e. pad(0,0,0,0), we will meet layout problem. However, it shouldn't be. I think I could do one quickfix in coreml frontend. (i.e. When we meet all pad values is zero, we avoid insert pad). I will make one pr tonight. @tqchen

I will try to spare time to construct one reproduce issue and try to find the root cause then fix it.

@FrozenGene FrozenGene deleted the coreml-fix branch September 10, 2019 13:40
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants