[Relay] Keras frontend upsample and 1 channel conv2d fixes #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
changed the title
|
@kazum, can you take a look? These are pretty minor fixes so it should be quick. |
|
@masahi, maybe you can take a look instead? |
|
@jwfromm, sorry for being late. I'll take a look today. |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
* Fix upsample layout in keras frontend. * Fixed group conv being used instead of conv when channels=1 * Add new conv2d test to catch bugs when channels=1.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
* Fix upsample layout in keras frontend. * Fixed group conv being used instead of conv when channels=1 * Add new conv2d test to catch bugs when channels=1.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 1, 2019
* Fix upsample layout in keras frontend. * Fixed group conv being used instead of conv when channels=1 * Add new conv2d test to catch bugs when channels=1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Discussion post found two bugs in Relay. The first was a silly mistake I introduced with the Resize rework (#3788 ) caused by defaulting to the wrong layout for upsample in the Keras frontend. I've resolved this issue and fixed the corresponding test. The second bug occurs when a convolution with 1 filter attempts to determine the shape of its weights. Relay checks for group convolutions by seeing if the number of channels equals the group size, however we obviously shouldn't if the number of channels is 1. I've added a new test to check for this failure in the future.