[Relay/Topi][Op] Added native DepthToSpace and SpaceToDepth Operators #4566

jwfromm · 2019-12-22T18:54:54Z

Although we previously supported DepthToSpace and SpaceToDepth in our frontends through the stacking of reshape, transpose, and another reshape operators, it was a clumsy and slow method as pointed out in Issue #4523. This PR adds direct DepthToSpace and SpaceToDepth operators in TOPI and corresponding Relay operations. I also replace the existing frontend calls to DepthToSpace and SpaceToDepth to show the simplification. In my brief testing, these new operators are around 1.5 to 2 times faster than our previous approach.

jwfromm · 2019-12-22T19:23:11Z

@icemelon9, can you take a look at this PR?

kice · 2019-12-23T00:15:52Z

python/tvm/relay/frontend/onnx.py

-        return AttrCvt(op_name="reshape",
-                       extras={'newshape': newshape},
-                       ignores=['mode', 'blocksize'])([transposed], attr)
+        return _op.nn.depth_to_space(inputs[0], block_size)


We need to handle eacho DepthToSpace mode differently.

For the record, PixelShuffle in Pytorch (onnx CRD mode) and depth_to_space in tensorflow (onnx DCR mode) is different.

Thank you for the correction. I never quite understood the use of CDR mode, but now that I know its how PyTorch handles depthtospace it makes much more sense. I added a mode argument to the depth_to_space operator that allows switching the channel indexing. Also added the proper mode parsing in the onnx frontend.

tqchen · 2019-12-24T02:18:07Z

@kice please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

tqchen · 2019-12-24T05:04:41Z

Thanks @jwfromm @kice !

…apache#4566) * Added tvm function stencil for subpixel operations to topi. * Topi subpixel operators added and tested. * Added subpixel attrs. * Added depth_to_space relay attributes. * depth_to_space fully working. * Fixed NHWC shape bug. * SpaceToDepth in and all tests passing. * lint fixes. * Added string include * Fixed topi formatting. * Added DCR/CDR mode to depthtospace operator.

@cchung100m

* Change upstream url * Fix bias_add gradient (apache#4516) * Fix bias_add gradient A change caused collapse_sum_like to reject implicit dimension broadcasting for bias_add gradient, so switch to explicit sum reduction on the non-bias axis dimensions. * Lint fix * [Bugfix][Frontend][TFlite] Fix wrong function call in TANH tests (apache#4517) * Replace sigmoid() with tanh() in tests for TANH * Fixed extra reshape parameter bug. (apache#4524) * Use the best tuner possible (apache#4397) * Use the best tuner possible * Add comment denoting availability of better tuners * Fix typos and wording * [ir] use DataType instead of Type for readability because Type has been deprecated (apache#4513) * add bfloat16 typeflag support (apache#4525) * fix empty config caused KeyError (apache#4520) * fix onnx shape dtype (apache#4528) * fix crash issue in tsim backend (apache#4527) * PIL is depreciated and should be replaced with pillow (a fork of PIL) (apache#4533) Change-Id: If2075df5475505f2da87dae7145af5a7ab83d8a4 * [Relay] External codegen (apache#4482) * Update legacy places from nnvm to relay. (apache#4535) * Update legacy places from nnvm to relay. This PR prepares the current mainline to remove nnvm compiler dep. * remove legacy stage * Implement 1d deconvolution (apache#4476) * [relay][op] add expand op (from ONNX) to relay frontend (apache#4483) * Add Expand to onnx.py * add test function for expand * Fix a onnx frontend test * Add tests for the value itself instead of shape only on test_expand * Cleaned up some unnecessary modifications. * [TOPI] Allow batch matmul to be fused into injective ops (apache#4537) * [TOPI] Fixed nms max_output_size loop (apache#4541) One of the loops in hybrid_nms used for performing the max_output_size reordering was incorrectly designated as parallel resulting in incorrect behaviour. This patch changes that loop to a serial loop. Change-Id: I97184f5887f5f028d8ab339fa2808eb7630a4017 * [DOCS] Mention Ninja build system in install/from_source.rst (apache#4554) * [DOCS] Mention Ninja build system in install/from_source.rst * Address comments * [PYTHON][FFI] Cythonize NDArray.copyto (apache#4549) * [PYTHON][FFI] Cythonize NDArray.copyto * Cythonize the shape property * vm external codegen (apache#4544) * [COMMUNITY] @cchung100m -> reviewer (apache#4557) * [VTA] improved virtual memory mapping (apache#4545) * [VTA] improved virtual memory mapping * Update virtual_memory.cc * [IR] fix style in ir_mutator and ir_visitor (apache#4561) * [RUNTIME][VULKAN] Fix compiler warning (apache#4559) * [REFACTOR][DTYPE] Isolate dtype to runtime (apache#4560) dtype.h -> runtime/data_type.h Changes: - Rename all old reference of tvm::Type to DataType - ExprNode.type -> ExprNode.dtype - Expr.type() -> Expr.dtype() - Change Expr related functions to expr_operator. - DataType::min() -> min_value(DataType) - DataType::max() -> max_value(DataType) - Move type constructor Int, UInt, Float, Handle, Bool into DataType. - Int(bits) -> DataType::Int(bits) - UInt(bits) -> DataType::UInt(bits) * Support standardize runtime module (apache#4532) * [Relay][Frontend][ONNX] Support auto_pad in Conv and ConvTranspose (apache#4563) * [TEST] Remove nnvm related code in topi and test script (apache#4562) * [TEST] Remove nnvm related code in topi and test script * Remove docs dep * [Relay] add max_pool3d in relay and TF converter (apache#4551) * [Relay] add max_pool3d in relay and TF converter * fix comments * Remove nnvm (apache#4565) * [VTA][Chisel] End-to-end Inference with Chisel VTA (apache#4574) * [VTA][Chisel] End-to-end Inference with Chisel VTA * Update TensorAlu.scala * remove unnecessary cast to int32 (apache#4573) * Fix llvm-enabled build by adding missing intrinsics headers (apache#4575) * [DEPRECATION] Remove NNVM compiler (apache#4571) * Remove NNVM compiler * [Relay/Topi][Op] Added native DepthToSpace and SpaceToDepth Operators (apache#4566) * Added tvm function stencil for subpixel operations to topi. * Topi subpixel operators added and tested. * Added subpixel attrs. * Added depth_to_space relay attributes. * depth_to_space fully working. * Fixed NHWC shape bug. * SpaceToDepth in and all tests passing. * lint fixes. * Added string include * Fixed topi formatting. * Added DCR/CDR mode to depthtospace operator. * [DOC] fix doc in api.py (apache#4580) * [DEPRECATION] Cleanup legacy verilog support (apache#4576) This PR cleans up the left over code for legacy verilog support which was experimental. The new hardware backend path is now support by VTA via TSIM. * [RUNTIME] Remove Extension VTable in favor of Unified Object system. (apache#4578) Before the unified object protocol, we support pass additional extension objects around by declaring a type as an extension type. The old extension mechanism requires the types to register their constructor and deleter to a VTable and does not enjoy the benefit of the self-contained deletion property of the new Object system. This PR upgrades the extension example to make use of the new object system and removed the old Extension VTable. Note that the register_extension funtion in the python side continues to work when the passed argument does not require explicit container copy/deletion, which covers the current usecases of the extension mechanism. * Some Windows and MSVC fixes (apache#4569) * fix python exception creation in Windows * better string conversion for msvc * fix cpp style issue * [NEWS] add v0.6 release (apache#4558) * [NEWS] add v0.6 release * remove link prefix * fix issue number * [DOCS]fix typos in autotvm tutorial (apache#4585) * [Quantization, Calibrate] Fix context creation when current_target is explicity set (apache#4582) * [Container] Fix NDArray SaveDLTensor declaration and implementation signature different (apache#4586) * [TOPI][AutoTVM] NHWC conv2d templates for ARM (apache#3859) * [AutoTVM][TOPI] NHWC conv2d templates (spatial pack) for ARM As some frontends (tflite for example) are using NHWC as the default layout, we are enabling NHWC schedule templates in TOPI and AutoTVM. * some comments fix * [FIX][TOPI][X86] schedule dense pack (apache#4539) * [Relay] Convert Layout Pass. (apache#4335) * [Relay][AlterLayout] Broadcast with scalar shape (apache#4577) * [TOPI] add 3D upsampling Op. (apache#4584) * [TOPI] add 3D upsampling Op. * fix lint issues * change align_corners to coordinate_transformation_mode * fix resize3d half_pixel * make a simple function and clean up trilinear_resize3d_python * fix doc * [Runtime] add necessary const qualifier for NDArray container of parameters (apache#4590) * [autotvm] fix typos in comment (apache#4591) * fix tf.compat.v1 issue for tf verison <=1.12 (apache#4593) * [FRONTEND][TF] conv2d_transpose 'SAME' support kernel more than 1x1 (apache#4484) * [FRONTEND][TF] conv3d_transpose 'SAME' support kernel more than 1x1 * revised per as review comments * add more fallback wolkaround to make all tests pass * [GraphRuntime] Support parameter out in the graph runtime debug (apache#4598) * [GraphRuntime] Support parameter out in the graph runtime debug * Dummy commit to trigger build * [Perf] Add CublasLt extern support for better Igemm performance (apache#4550) * cublaslt added * fix lint * address comments * address more comments * Trigger CI * Trigger CI * fix codegenc (apache#4597) * [REFACTOR][RUNTIME] Update NDArray use the Unified Object System (apache#4581) * [REFACTOR][RUNTIME] Move NDArray to Object System. Previously NDArray has its own object reference counting mechanism. This PR migrates NDArray to the unified object protocol. The calling convention of NDArray remained intact. That means NDArray still has its own type_code and its handle is still DLTensor compatible. In order to do so, this PR added a few minimum runtime type detection in TVMArgValue and RetValue only when the corresponding type is a base type(ObjectRef) that could also refer to NDArray. This means that even if we return a base reference object ObjectRef which refers to the NDArray. The type_code will still be translated correctly as kNDArrayContainer. If we assign a non-base type(say Expr) that we know is not compatible with NDArray during compile time, no runtime type detection will be performed. This PR also adopts the object protocol for NDArray sub-classing and removed the legacy NDArray subclass protocol. Examples in apps/extension are now updated to reflect that. Making NDArray as an Object brings all the benefits of the object system. For example, we can now use the Array container to store NDArrays. * Address review comments * [Relay][Convert Layout] Handling batch norm layout change. (apache#4600) * [relay][refactor] Cache Op::Get in passes to reduce lookup overhead (apache#4594) * Refactor to use IsOp utility * retrigger CI * Update dmlc_tvm_commit_id.txt * disable one test_batch_norm unit test for now to check CI * enable test_batch_norm Co-authored-by: SWu <SWu@users.noreply.github.com> Co-authored-by: Ina Dobreva <55383260+inadob@users.noreply.github.com> Co-authored-by: Josh Fromm <jwfromm@uw.edu> Co-authored-by: miheer vaidya <v.miheer@gmail.com> Co-authored-by: Liang ZOU <liang.d.zou@gmail.com> Co-authored-by: YixinBao <yixin.bao@intel.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: masahi <masahi129@gmail.com> Co-authored-by: Liangfu Chen <liangfu.chen@icloud.com> Co-authored-by: lhutton1 <35535092+lhutton1@users.noreply.github.com> Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Alex Gladkov <gladkov_alex@yahoo.com> Co-authored-by: Takato Yamada <tkclimb0911@gmail.com> Co-authored-by: Haichen Shen <shenhaichen@gmail.com> Co-authored-by: mbarrett97 <55580676+mbarrett97@users.noreply.github.com> Co-authored-by: Hideto Ueno <uenoku.tokotoko@gmail.com> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> Co-authored-by: Zhao Wu <wuzhaozju@gmail.com> Co-authored-by: Neo Chien <cchung100m@cs.ccu.edu.tw> Co-authored-by: Yong Wu <55wuyong@163.com> Co-authored-by: Dmitri Makarov <dmakarov@users.noreply.github.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: kice <wslikerqs@gmail.com> Co-authored-by: Yizhi Liu <liuyizhi@apache.org> Co-authored-by: Wang Yucheng <wyc91543@163.com> Co-authored-by: 王振华(Zhenhua WANG) <i@jackwish.net> Co-authored-by: deepIgnorance <zhengsizemax@outlook.com> Co-authored-by: Animesh Jain <anijain@umich.edu> Co-authored-by: optima2005 <56945758+optima2005@users.noreply.github.com> Co-authored-by: zhuochen <zhuochen@outlook.com> Co-authored-by: Leyuan Wang <laurawly@gmail.com>

…apache#4566) * Added tvm function stencil for subpixel operations to topi. * Topi subpixel operators added and tested. * Added subpixel attrs. * Added depth_to_space relay attributes. * depth_to_space fully working. * Fixed NHWC shape bug. * SpaceToDepth in and all tests passing. * lint fixes. * Added string include * Fixed topi formatting. * Added DCR/CDR mode to depthtospace operator.

CoinCheung · 2020-01-20T06:26:23Z

Hi, Does tvm fully support the op of depth_to_space now ?
I got the error message in my code that I do not know whether it is associated with this operator:

Traceback (most recent call last):

  File "run_onnx.py", line 88, in <module>
    graph, lib, params = compile_model()

  File "run_onnx.py", line 53, in compile_model
    mod, params = relay.frontend.from_onnx(model, shape_dict, dtype='float32', opset=11)

  File "/root/build/tvm/python/tvm/relay/frontend/onnx.py", line 1586, in from_onnx
    mod, params = g.from_onnx(graph, opset)

  File "/root/build/tvm/python/tvm/relay/frontend/onnx.py", line 1414, in from_onnx
    op = self._convert_operator(op_name, inputs, attr, opset)

  File "/root/build/tvm/python/tvm/relay/frontend/onnx.py", line 1514, in _convert_operator
    sym = convert_map[op_name](inputs, attrs, self._params)

  File "/root/build/tvm/python/tvm/relay/frontend/onnx.py", line 574, in _impl_v11
    return _op.nn.depth_to_space(inputs[0], block_size, mode=mode)

  File "/root/build/tvm/python/tvm/relay/op/nn/nn.py", line 2374, in depth_to_space
    return _make.depth_to_space(data, block_size, layout, mode)

  File "tvm/_ffi/_cython/./function.pxi", line 304, in tvm._ffi._cy3.core.FunctionBase.__call__

  File "tvm/_ffi/_cython/./function.pxi", line 248, in tvm._ffi._cy3.core.FuncCall

  File "tvm/_ffi/_cython/./function.pxi", line 172, in tvm._ffi._cy3.core.make_arg

TypeError: Don't know how to handle type <class 'bytes'>

kice · 2020-01-20T11:03:39Z

Yes it does, but this pr forgot to decode the byte to string. You could add a line to decode the mode to string.

CoinCheung · 2020-01-20T13:37:32Z

@kice Thanks for replying !!! I am not familiar with the source code, would you please add a pr to fix this, or would you tell me where should I modify to make my code work ?

kice · 2020-01-20T16:12:34Z

Please give it a try #4750

CoinCheung · 2020-01-21T05:03:54Z

Thanks, it works for me.

jwfromm added 8 commits December 22, 2019 10:27

Added tvm function stencil for subpixel operations to topi.

84a9ea2

Topi subpixel operators added and tested.

154c529

Added subpixel attrs.

32d27c9

Added depth_to_space relay attributes.

f317f0d

depth_to_space fully working.

7f988fa

Fixed NHWC shape bug.

9d360dc

SpaceToDepth in and all tests passing.

4d72eba

lint fixes.

2704f8c

jwfromm mentioned this pull request Dec 22, 2019

Optimization for subpixel layer on Tensor core #4523

Closed

Added string include

4918e8e

jwfromm changed the title ~~[Relay][Topi] Added native DepthToSpace and SpaceToDepth Operators~~ [Relay/Topi][Op] Added native DepthToSpace and SpaceToDepth Operators Dec 22, 2019

Fixed topi formatting.

0dd3971

kice reviewed Dec 23, 2019

View reviewed changes

Added DCR/CDR mode to depthtospace operator.

f4f10b1

tqchen added the status: need review label Dec 24, 2019

kice approved these changes Dec 24, 2019

View reviewed changes

tqchen approved these changes Dec 24, 2019

View reviewed changes

tqchen merged commit 9b92c53 into apache:master Dec 24, 2019

tqchen added status: accepted and removed status: need review labels Dec 24, 2019

jwfromm deleted the subpixel branch January 11, 2020 22:54

kice mentioned this pull request Jan 20, 2020

Fix onnx import bugs #4750

Merged

zhiics mentioned this pull request Sep 15, 2020

TVM v0.7 Release Note Candidate #6486

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Relay/Topi][Op] Added native DepthToSpace and SpaceToDepth Operators #4566

[Relay/Topi][Op] Added native DepthToSpace and SpaceToDepth Operators #4566

jwfromm commented Dec 22, 2019

jwfromm commented Dec 22, 2019

kice Dec 23, 2019

jwfromm Dec 23, 2019 •

edited

tqchen commented Dec 24, 2019

tqchen commented Dec 24, 2019

CoinCheung commented Jan 20, 2020

kice commented Jan 20, 2020

CoinCheung commented Jan 20, 2020

kice commented Jan 20, 2020

CoinCheung commented Jan 21, 2020

[Relay/Topi][Op] Added native DepthToSpace and SpaceToDepth Operators #4566

[Relay/Topi][Op] Added native DepthToSpace and SpaceToDepth Operators #4566

Conversation

jwfromm commented Dec 22, 2019

jwfromm commented Dec 22, 2019

kice Dec 23, 2019

Choose a reason for hiding this comment

jwfromm Dec 23, 2019 • edited

Choose a reason for hiding this comment

tqchen commented Dec 24, 2019

tqchen commented Dec 24, 2019

CoinCheung commented Jan 20, 2020

kice commented Jan 20, 2020

CoinCheung commented Jan 20, 2020

kice commented Jan 20, 2020

CoinCheung commented Jan 21, 2020

jwfromm Dec 23, 2019 •

edited