Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] fskip of EliminateCommonSubexpr cannot always return false #4620

Merged
merged 2 commits into from
Jan 11, 2020
Merged

[Bugfix] fskip of EliminateCommonSubexpr cannot always return false #4620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f987f2
'fskip' will not always return false
yuliujq Jan 4, 2020
ba82910
Update build_module.cc
yuliujq Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/relay/backend/build_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ class RelayBuildModule : public runtime::ModuleNode {
pass_seqs.push_back(transform::SimplifyInference());
PackedFunc fskip = PackedFunc([](TVMArgs args, TVMRetValue* rv) {
Expr expr = args[0];
*rv = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default return false

if (expr.as<CallNode>()) {
auto call_node = expr.as<CallNode>();
auto op_node = call_node->op.as<OpNode>();
Expand All @@ -328,7 +329,6 @@ class RelayBuildModule : public runtime::ModuleNode {
}
}
}
*rv = false;
});
pass_seqs.push_back(transform::EliminateCommonSubexpr(fskip));
pass_seqs.push_back(transform::CombineParallelConv2D(3));
Expand Down