Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix topi.nn.global_pool layout="NHWC" #4656

Merged
merged 5 commits into from Jan 10, 2020
Merged

fix topi.nn.global_pool layout="NHWC" #4656

merged 5 commits into from Jan 10, 2020

Conversation

qihaitao
Copy link
Contributor

@qihaitao qihaitao commented Jan 8, 2020

No description provided.

Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fort the contribution, please add a regression test case

topi/src/topi.cc Outdated Show resolved Hide resolved
@tqchen tqchen added the status: need test case need test cases to cover the change label Jan 8, 2020
topi/src/topi.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@kevinthesun kevinthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen tqchen merged commit 8d83da6 into apache:master Jan 10, 2020
@tqchen
Copy link
Member

tqchen commented Jan 10, 2020

Thanks @kevinthesun @qihaitao !

@tqchen tqchen added status: accepted and removed status: need test case need test cases to cover the change labels Jan 10, 2020
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
* Update topi.cc

fix topi.nn.global_pool layout="NHWC"

* add topi.nn.global_pool layout=NHWC test
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
* Update topi.cc

fix topi.nn.global_pool layout="NHWC"

* add topi.nn.global_pool layout=NHWC test
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
* Update topi.cc

fix topi.nn.global_pool layout="NHWC"

* add topi.nn.global_pool layout=NHWC test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants