Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action lint Python code for syntax errors #4688

Merged
merged 4 commits into from Jan 12, 2020
Merged

GitHub Action lint Python code for syntax errors #4688

merged 4 commits into from Jan 12, 2020

Commits on Jan 11, 2020

  1. GitHub Action lint Python code for syntax errors 

    https://flake8.pycqa.org/en/latest/user/error-codes.html

On the flake8 test selection, this PR does _not_ focus on "_style violations_" (the majority of flake8 error codes that [__psf/black__](https://github.com/psf/black) can autocorrect).  Instead these tests are focus on runtime safety and correctness:
* E9 tests are about Python syntax errors usually raised because flake8 can not build an Abstract Syntax Tree (AST).  Often these issues are a sign of unused code or code that has not been ported to Python 3.  These would be compile-time errors in a compiled language but in a dynamic language like Python they result in the script halting/crashing on the user.
* F63 tests are usually about the confusion between identity and equality in Python.  Use ==/!= to compare str, bytes, and int literals is the classic case.  These are areas where __a == b__ is True but __a is b__ is False (or vice versa).  Python >= 3.8 will raise SyntaxWarnings on these instances.
* F7 tests logic errors and syntax errors in type hints
* F82 tests are almost always _undefined names_ which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3.  These also would be compile-time errors in a compiled language but in Python a __NameError__ is raised which will halt/crash the script on the user.
    @cclauss
    cclauss committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    b8ee7f5 View commit details
    Browse the repository at this point in the history

  2. Force a retest

    @cclauss
    cclauss committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    a37c324 View commit details
    Browse the repository at this point in the history

  3. Rename start_rpc_server_to_tracker.py to start_rpc_server_to_tracker.sh 

    This is a bash file, not a Python file.
    @cclauss
    cclauss committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    ce836f4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into patch-3

    @cclauss
    cclauss committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    b9bf237 View commit details
    Browse the repository at this point in the history