Make sure to visit the arguments of inlined functions #4783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
approved these changes
Jan 30, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #4758
I found out what causes the issue. The module I test with has two CallNode expressions that reference the match clause:
%5 = @fn(%4);andadd(%2, %5).One of these uses the GlobalVarNode path at line https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/vm/inline_primitives.cc#L94 which doesn't visit its arguments but just uses them directly from the original expression.
The other uses the default path at the end of the CallNode visitor which does visit its arguments, clones the match and uses it for the new call node it returns.
My fix is to always visit the arguments so that all path use the same "version" of the expressions.