Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime] Export GraphRuntime in tvm_runtime.dll #5002

Merged
merged 1 commit into from Mar 6, 2020

Conversation

soiferj
Copy link
Contributor

@soiferj soiferj commented Mar 6, 2020

Currently, the GraphRuntime class is unusable in C++ from Windows. This change exposes the class.

@jmorrill would you be able to take a look?

@jmorrill
Copy link
Contributor

jmorrill commented Mar 6, 2020

@soiferj This is where it gets a little embarrassing for me. I've never been able to get a good link to tvm_runtime.dll, even using tvm_runtime_pack.cc without some other changes...So like killing a a fly with a rocket launcher, I work off this CMake change:

https://github.com/jmorrill/tvm/blob/cc0b1e750512b690bbecc9e98a30f7a9945843b1/CMakeLists.txt#L282 aka "export everything"

I can try again to get this tvm_runtime_pack.cc method to give me a link and then see if your fix solves it :).

@jmorrill
Copy link
Contributor

jmorrill commented Mar 6, 2020

@soiferj Thank you. This fixes my need to have set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) and can re-enable INTERPROCEDURAL_OPTIMIZATION on it.

tvm_runtime.dll links fine on VS2019!

@soiferj
Copy link
Contributor Author

soiferj commented Mar 6, 2020

Awesome! Thanks @jmorrill. Would you mind approving the PR if it looks good? :)

Copy link
Contributor

@jmorrill jmorrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'm authoritative on approving PRs (or if i know how to do it).

Works on my machine.

Thanks!

@tqchen tqchen merged commit e5044cb into apache:master Mar 6, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
Co-authored-by: Jon Soifer <jonso@microsoft.com>
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
Co-authored-by: Jon Soifer <jonso@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants