Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add python setup script #6844

Merged
merged 1 commit into from Nov 4, 2020
Merged

[CI] Add python setup script #6844

merged 1 commit into from Nov 4, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Nov 4, 2020

To enable setup less stable python packages more quickly and avoid frequent docker update.

@tqchen
Copy link
Member Author

tqchen commented Nov 4, 2020

cc @tmoreau89 @tkonolige

tmoreau89
tmoreau89 approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ANSHUMAN87
ANSHUMAN87 approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@ANSHUMAN87 ANSHUMAN87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tqchen , This is indeed required. 👍

@ANSHUMAN87
Copy link
Contributor

Just one thought, based on recent struggle in upgrading TF with a cascade effect. Should we have an option to override the existing dependency packages ? So that we can run the CI, with the intended dependency package without modifying the docker. Later on, once CI stable, we can change the docker.

@tqchen tqchen merged commit 5471cd2 into apache:main Nov 4, 2020
@tqchen
Copy link
Member Author

tqchen commented Nov 4, 2020 •
edited

I believe pip install --user package==version would have the precedance over the system installed package

Confirm by the following experiment

docker/bash.sh tlcpack/ci-gpu:v0.71
# the system one
python3 -m pip show mxnet
# install a specific version
python3 -m pip install --user mxnet==1.5.0
python3 -m pip show mxnet

@ANSHUMAN87
Copy link
Contributor

Thanks @tqchen for confirming. I concur. 👍

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
@tqchen
[CI] Add python setup script (apache#6844)
8b7590f
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
@tqchen
[CI] Add python setup script (apache#6844)
275d3de
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
@tqchen @trevor-m
[CI] Add python setup script (apache#6844)
9714334
@tqchen tqchen deleted the ci-stage2 branch February 26, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmoreau89 tmoreau89 tmoreau89 approved these changes

@ANSHUMAN87 ANSHUMAN87 ANSHUMAN87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tqchen @ANSHUMAN87 @tmoreau89