[Bugfix][Module] Fix recursive GetFunction in runtime::Module #6859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
approved these changes
Nov 6, 2020
giuseros
reviewed
Nov 6, 2020
| @@ -68,6 +68,9 @@ PackedFunc ModuleNode::GetFunction(const std::string& name, bool query_imports) | |||
| if (query_imports) { | |||
| for (Module& m : self->imports_) { | |||
| pf = m.operator->()->GetFunction(name, query_imports); | |||
| if (pf != nullptr) { | |||
| return pf; | |||
| } | |||
| } | |||
| } | |||
| return pf; | |||
There was a problem hiding this comment.
Would it be worth (and correct) putting an assert like ICHECK(pf != nullptr) << "unable to get the function pointer" ?
There was a problem hiding this comment.
The expected behvaior of this function is to return nullptr for functions inavailable, so we don't want to put ICHECKhere
tqchen
approved these changes
Nov 6, 2020
|
Thanks @junrushao1994 ! Please also send another PR to https://github.com/apache/incubator-tvm/tree/v0.7 branch |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that affects the behavior of
ModuleNode::GetFunctionwhenquery_import=TrueCC: @jwfromm @tqchen @icemelon9