Lazy import XGBoost #6939
Merged
Lazy import XGBoost #6939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
approved these changes
Nov 19, 2020
tqchen
approved these changes
Nov 19, 2020
|
@comaniac Missing the package is a fatal error. We should raise an exception when we fail to import it instead of prinitng a message. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered the same issue as this one: https://discuss.tvm.apache.org/t/conflict-with-xgboost-when-thrust-is-enabled/6889 with CUDA 10.0 and thrust enabled after upgrading XGBoost to 1.1.0. Since XGBoost is imported by AutoTVM, and AutoTVM is used everywhere (e.g., TOPI, VM, etc), I got the error even with only
from tvm import relay, as mentioned in the latest reply in the post.Since we cannot reproduce this error in docker and it's a potential issue, this PR makes the XGBoost import lazy.
cc @merrymercy @tqchen @vinx13 @zhiics