Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for debug builds in micro_session.cc #6968

Merged
merged 1 commit into from Nov 24, 2020
Merged

Bug fix for debug builds in micro_session.cc #6968

merged 1 commit into from Nov 24, 2020

Conversation

manupak
Copy link
Contributor

@manupak manupak commented Nov 24, 2020

  • kReceiveBufferSizeBytes is declared but not defined (as it is a static constexpr)
  • If the build decides not to inline kReceiveBufferSizeBytes, we will encounter a linking error.
  • This was seen as an issue in the Debug builds.

Discuss : https://discuss.tvm.apache.org/t/ci-c-standard-for-the-tvm-project/8508/3

cc: @areusch @tqchen

@manupak
Bug fix for debug builds in micro_session.cc
3cd0675 
* If the build decides not to inline kReceiveBufferSizeBytes,
  we will encounter a linking error.

Change-Id: Ibbe5b20fdd63acb2b4652ca9896f5737eaf14b00
areusch
areusch approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @manupa-arm !

@tqchen tqchen merged commit 448278d into apache:main Nov 24, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
@manupak
Bug fix for debug builds in micro_session.cc (apache#6968)
08eeca0 
* If the build decides not to inline kReceiveBufferSizeBytes,
  we will encounter a linking error.

Change-Id: Ibbe5b20fdd63acb2b4652ca9896f5737eaf14b00
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
@manupak
Bug fix for debug builds in micro_session.cc (apache#6968)
ed62b3f 
* If the build decides not to inline kReceiveBufferSizeBytes,
  we will encounter a linking error.

Change-Id: Ibbe5b20fdd63acb2b4652ca9896f5737eaf14b00
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
@manupak @trevor-m
Bug fix for debug builds in micro_session.cc (apache#6968)
616ef76 
* If the build decides not to inline kReceiveBufferSizeBytes,
  we will encounter a linking error.

Change-Id: Ibbe5b20fdd63acb2b4652ca9896f5737eaf14b00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areusch areusch areusch approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manupak @areusch @tqchen