New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay][Strategy] Allow cuda cross compilation without physical device. #7063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@anwang2009 @tqchen @adelbertc Can you guys take a look at this PR? |
comaniac
requested changes
Dec 8, 2020
anwang2009
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm afaict
comaniac
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a nit.
Thanks @jwfromm @anwang2009. |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
…e. (apache#7063) * Allow cross compilation of cuda targets without physical device. * Formatting. * Add warning when architecture cant be found. * Use target instead of autotvm arch specification. * Change warning message. Co-authored-by: Ubuntu <jwfromm@jwfromm-cpu-dev.itxhlkosmouevgkdrmwxfbs5qh.xx.internal.cloudapp.net>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
…e. (apache#7063) * Allow cross compilation of cuda targets without physical device. * Formatting. * Add warning when architecture cant be found. * Use target instead of autotvm arch specification. * Change warning message. Co-authored-by: Ubuntu <jwfromm@jwfromm-cpu-dev.itxhlkosmouevgkdrmwxfbs5qh.xx.internal.cloudapp.net>
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…e. (apache#7063) * Allow cross compilation of cuda targets without physical device. * Formatting. * Add warning when architecture cant be found. * Use target instead of autotvm arch specification. * Change warning message. Co-authored-by: Ubuntu <jwfromm@jwfromm-cpu-dev.itxhlkosmouevgkdrmwxfbs5qh.xx.internal.cloudapp.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of tensorcore schedules has broken TVM's ability to compile for cuda on a machine without a GPU. This is because the strategy registration for tensorcores calls
tvm.gpu(0).compute_version
, which fails when no gpu is present. I've changed the behavior ofnvcc.have_tensorcore
to checkAutotvmGlobalScope.current.cuda_target_arch
when a GPU isn't present. This allows a user to call something liketvm.autotvm.measure.measure_methods.set_cuda_target_arch("sm_62")
to specify a cuda cross compilation target on a machine without a GPU and build correctly.I'm not sure how to test this since it would require a CPU node that's built with the cuda toolkit. Let me know if you have an opinion on tests to add to prevent an error like this from sneaking in again.