Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Autoscheduler] Costmodel enhancement #7197

Merged
merged 12 commits into from Jan 6, 2021
Merged

Conversation

jcf94
Copy link
Contributor

@jcf94 jcf94 commented Jan 4, 2021

This PR contains some small enhancements and fix:

@jcf94
Copy link
Contributor Author

jcf94 commented Jan 4, 2021

Thanks! @junrushao1994
Also cc @merrymercy @comaniac

python/tvm/auto_scheduler/task_scheduler.py Outdated Show resolved Hide resolved
src/auto_scheduler/feature.cc Show resolved Hide resolved
python/tvm/auto_scheduler/cost_model/xgb_model.py Outdated Show resolved Hide resolved
@merrymercy merrymercy self-assigned this Jan 4, 2021
model_file=load_model_file,
)
if load_log_file:
logger.info("TaskScheduler: Reload measured states and train the model...")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load_model_file and load_log_file are mutually exclusive, because update_from_file will retrain a model and overwrite the loaded model.
I think the old code is better.

I don't know why the old code cannot satisfy your need.

Copy link
Contributor Author

@jcf94 jcf94 Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old one is fine. I was just going to add a self.model_file for cost model saving after training, this was modified by the way.

python/tvm/auto_scheduler/cost_model/xgb_model.py Outdated Show resolved Hide resolved
python/tvm/auto_scheduler/cost_model/xgb_model.py Outdated Show resolved Hide resolved
@jcf94 jcf94 requested a review from comaniac January 6, 2021 01:56
@comaniac comaniac merged commit 040afb0 into apache:main Jan 6, 2021
@comaniac
Copy link
Contributor

comaniac commented Jan 6, 2021

Thanks @jcf94 @merrymercy @areusch @junrushao1994

@jcf94 jcf94 deleted the bug_fix branch January 6, 2021 08:46
@jcf94 jcf94 changed the title [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime [Fix][Autoscheduler] Costmodel enhancement Jan 8, 2021
tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this pull request Jan 11, 2021
…runtime (apache#7197)

* Enhancement for autoscheduler cost model

* Bug fix for graph_runtime_debug

* Update

* Lint fix

* Update

* Update

* Add file exist check for cost model load

* Update

* Update

* Lint fix

* Update

* Bug fix
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 14, 2021
…runtime (apache#7197)

* Enhancement for autoscheduler cost model

* Bug fix for graph_runtime_debug

* Update

* Lint fix

* Update

* Update

* Add file exist check for cost model load

* Update

* Update

* Lint fix

* Update

* Bug fix
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
…runtime (apache#7197)

* Enhancement for autoscheduler cost model

* Bug fix for graph_runtime_debug

* Update

* Lint fix

* Update

* Update

* Add file exist check for cost model load

* Update

* Update

* Lint fix

* Update

* Bug fix
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
…runtime (apache#7197)

* Enhancement for autoscheduler cost model

* Bug fix for graph_runtime_debug

* Update

* Lint fix

* Update

* Update

* Add file exist check for cost model load

* Update

* Update

* Lint fix

* Update

* Bug fix
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
…runtime (apache#7197)

* Enhancement for autoscheduler cost model

* Bug fix for graph_runtime_debug

* Update

* Lint fix

* Update

* Update

* Add file exist check for cost model load

* Update

* Update

* Lint fix

* Update

* Bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants