[µTVM] Fix two warnings when deprecated forms are used #7269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify the loader to be used by yaml.load as the current form used without specifying explicitly a loader is deprecated since PyYAML 5.1 and will throw a noisy warning. For details, please see: https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Avoid using tvm.target.create as it's deprecated and use tvm.target.Target directly instead. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
|
@areusch Hi. Could you review that small patchset, please? For warning [0] I'm assuming microTVM is not locked with any old PyYAML version (i.e. < 5.1). If it's locked we could simply silence the warning, which is not so nice I think. Thanks! |
|
thanks for fixing these @gromero! @tmoreau89 @tqchen |
areusch
approved these changes
Jan 13, 2021
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 14, 2021
* [µTVM] Specify loader for yaml.load Specify the loader to be used by yaml.load as the current form used without specifying explicitly a loader is deprecated since PyYAML 5.1 and will throw a noisy warning. For details, please see: https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> * [µTVM] Avoid using tvm.target.create Avoid using tvm.target.create as it's deprecated and use tvm.target.Target directly instead. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 18, 2021
* [µTVM] Specify loader for yaml.load Specify the loader to be used by yaml.load as the current form used without specifying explicitly a loader is deprecated since PyYAML 5.1 and will throw a noisy warning. For details, please see: https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> * [µTVM] Avoid using tvm.target.create Avoid using tvm.target.create as it's deprecated and use tvm.target.Target directly instead. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
* [µTVM] Specify loader for yaml.load Specify the loader to be used by yaml.load as the current form used without specifying explicitly a loader is deprecated since PyYAML 5.1 and will throw a noisy warning. For details, please see: https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> * [µTVM] Avoid using tvm.target.create Avoid using tvm.target.create as it's deprecated and use tvm.target.Target directly instead. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
* [µTVM] Specify loader for yaml.load Specify the loader to be used by yaml.load as the current form used without specifying explicitly a loader is deprecated since PyYAML 5.1 and will throw a noisy warning. For details, please see: https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> * [µTVM] Avoid using tvm.target.create Avoid using tvm.target.create as it's deprecated and use tvm.target.Target directly instead. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* [µTVM] Specify loader for yaml.load Specify the loader to be used by yaml.load as the current form used without specifying explicitly a loader is deprecated since PyYAML 5.1 and will throw a noisy warning. For details, please see: https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> * [µTVM] Avoid using tvm.target.create Avoid using tvm.target.create as it's deprecated and use tvm.target.Target directly instead. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This patchset addresses the following two warnings on microTVM:
[0]
[1]
Warning [0] is related to the deprecated form (no loader specified) of yaml.load(input), while the second one is related to the use of deprecated tvm.target.create().
Both warnings appear when running
micro_tflite.py. The first one [0] whenTARGET = tvm.target.target.micro("stm32f746xx")and the second one [1] whenTARGET = tvm.target.target.micro("host"), which is the default target.Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.