[RELAY][Parser] Optimize relay parser to restore calls attrs #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or calls * To avoid too much modification to the native class, only print out the attrs type key of non-Operator Call in relay printer. Then reconstruct the attrs object after parsing this attrs type key value in Relay parser.
|
I think the change makes sense, but could you add a few test cases to the parser and I will take another look? Thanks for the fix! |
Thanks for the reminder @jroesch |
|
Rebased on master. |
|
Sorry I some how missed the notification for this one, LGTM thanks! |
jroesch
approved these changes
Feb 23, 2021
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…7347) * [RELAY][Parser] Optimize relay parser to restore attrs for non-Operator calls * To avoid too much modification to the native class, only print out the attrs type key of non-Operator Call in relay printer. Then reconstruct the attrs object after parsing this attrs type key value in Relay parser. * fix lint * fix ci * add test case
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…7347) * [RELAY][Parser] Optimize relay parser to restore attrs for non-Operator calls * To avoid too much modification to the native class, only print out the attrs type key of non-Operator Call in relay printer. Then reconstruct the attrs object after parsing this attrs type key value in Relay parser. * fix lint * fix ci * add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay parser does not support to restore the attrs value when it is a non-OpNode call.
To avoid too much modification to the native code, only print out the attrs type key of non-Operator Call in relay printer. Then reconstruct the attrs object after parsing this attrs_type_key value in Relay parser.
@jroesch please review.