[Relay][Frontend[Onnx] Add testing for output datatypes and fix related bugs. #7364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
approved these changes
Jan 28, 2021
|
please fix the lint issue |
masahi
approved these changes
Jan 29, 2021
|
thanks @jwfromm @mbrookhart |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
…ed bugs. (apache#7364) * Add testing for datatypes and fix related bugs. * Fix lint issue in onnx.
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…ed bugs. (apache#7364) * Add testing for datatypes and fix related bugs. * Fix lint issue in onnx.
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…ed bugs. (apache#7364) * Add testing for datatypes and fix related bugs. * Fix lint issue in onnx.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…ed bugs. (apache#7364) * Add testing for datatypes and fix related bugs. * Fix lint issue in onnx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@masahi encountered a bug due to our importer using int32 for topk rather than onnx's specified int64. To prevent similar errors, I've added an output datatype check to our onnx tests. This check uncovered a datatype mismatch in ArgMin and ArgMax that are also fixed in this PR.