Report JUnit test results for all TVM Python tests #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandron
reviewed
Feb 12, 2021
There was a problem hiding this comment.
Do you prefer to prefix the test case names e.g.
cython-tests.python.unittest.test_arith_canonical_simplify.test_split_index_simplify?
I think the prefixing is a good idea, to make that obvious. I never got into the internals of JUnit reporting (just used directly to publish on Jenkins, as you're enabling here) so I don't know how complex that change is.
Out of curiosity, are the test scripts already publishing the xml reports?
tkonolige
approved these changes
Feb 15, 2021
|
I had thought I pushed |
|
@leandron please explicitly approve if you're ok w/ this. |
junrushao
approved these changes
Feb 17, 2021
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* Enable JUnit parsing for Python tests * retrigger CI * prefix junit results with FFI type * remove - in junit prefix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* Enable JUnit parsing for Python tests * retrigger CI * prefix junit results with FFI type * remove - in junit prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables JUnitXML output from pytest for all TVM python testing. The goal is to enable us to better understand which TVM tests are slow, how a change might impact them, and the runtime variance we see in the TVM CI.
See the example test report produced from the staging run on this PR.
Note that a previous staging run did timeout in the frontend tests, but by a long shot, so I think there's a chance it was unrelated to this PR.
For discussion
>button on the graph) at both the test level and at the test group level.pytestcan be configured to add a prefix per-run, so we could fix this easily right now. On the other hand, adding the prefix could clutter the test output and make it harder to scan.cython-tests.python.unittest.test_arith_canonical_simplify.test_split_index_simplify?@tqchen @junrushao1994 @tkonolige @jroesch @zhiics @comaniac @u99127 @manupa-arm @leandron