Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autoscheduler][VM] Autoscheduler layout rewrite pass to VM #7516

Merged
merged 8 commits into from Mar 2, 2021

Conversation

tmoreau89
Copy link
Contributor

This adds the autoscheduler layout rewrite pass to VM compiler, to brings big performance improvements to any autoscheduler optimized graph. Tested on SSD Resnet34 and saw over 2x speedup.

@tmoreau89
Copy link
Contributor Author

@merrymercy merrymercy marked this pull request as ready for review February 26, 2021 00:22
merrymercy
merrymercy previously approved these changes Feb 26, 2021
@merrymercy
Copy link
Member

merrymercy commented Feb 26, 2021

How can we address this kind of issue in the future?

Should we organize the optimization passes in src/relay/backend/vm/compiler.cc and src/relay/backend/build_module.cc into a common place? So we don't need to add every new pass in two places.

@tmoreau89
Copy link
Contributor Author

@merrymercy I think that initially the intent for Relay VM compilation was to use the same passes as the graph runtime. I think that the pass manager refactor ended up being applied to graph runtime and not the VM IIRC causing the two to diverge?
@jroesch and @tkonolige has some input on this and we could think of a plan to unify the passes since technically the two runtimes should use the same passes. This could use an RFC but I think everyone will be behind it.

@tmoreau89
Copy link
Contributor Author

@merrymercy please let me know if there are any outstanding changes requested of if we can go ahead and merge this one

@tmoreau89 tmoreau89 merged commit a1d43c1 into apache:main Mar 2, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
)

* fix type inference for conv2d

* fix

* adding the autoscheduler layout rewrite pass to VM compiler passes

* revert edits applied in other PR

* minor fix

* fix

* formatting fix

* lint
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
)

* fix type inference for conv2d

* fix

* adding the autoscheduler layout rewrite pass to VM compiler passes

* revert edits applied in other PR

* minor fix

* fix

* formatting fix

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants