Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCKER] Fix: install script regarding get-pip.py during docker build #7579

Merged
merged 2 commits into from Mar 4, 2021

Conversation

brianlan
Copy link
Contributor

@brianlan brianlan commented Mar 3, 2021

Replaced the URL of get-pip.py from

https://bootstrap.pypa.io/get-pip.py

to

https://bootstrap.pypa.io/2.7/get-pip.py

, as the old one doesn't support python 2.7 any more and triggers below error during the building of Dockerfile.demo_android.

ERROR: This script does not work on Python 2.7 The minimum supported Python version is 3.6.

Other than this, the whole docker building procedure works OK.

@leandron Could you please help to review? Thanks.

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a legitimate fix for Python 2.7 setup scripts.

Just would like to check with @tqchen what's the status of our support in general to Python 2.7. Is this something we support in TVM?

@tqchen
Copy link
Member

tqchen commented Mar 3, 2021

we have dropped the support for python2.7 in the current mainline, so let us consider remove the python2 setup of pip instead. Thank you @brianlan

@brianlan
Copy link
Contributor Author

brianlan commented Mar 3, 2021

we have dropped the support for python2.7 in the current mainline, so let us consider remove the python2 setup of pip instead. Thank you @brianlan

Thanks @leandron, @tqchen. Will remove python2 setup and test again.

@brianlan
Copy link
Contributor Author

brianlan commented Mar 4, 2021

Removed get-pip.py for python2. I rerun the whole docker build process, it works fine. @tqchen

@tqchen tqchen merged commit 66f9139 into apache:main Mar 4, 2021
@tqchen
Copy link
Member

tqchen commented Mar 4, 2021

Thanks @brianlan @leandron !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants