Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Pass] Avoid stack overflow when using PostOrderRewrite #7588

Merged
merged 3 commits into from Mar 5, 2021

Conversation

hgt312
Copy link
Contributor

@hgt312 hgt312 commented Mar 4, 2021

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

Avoid stack overflow when there are many let nodes.

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, but otherwise this looks good to me.

src/relay/ir/expr_functor.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yzhliu yzhliu merged commit 1ae4697 into apache:main Mar 5, 2021
@yzhliu
Copy link
Member

yzhliu commented Mar 5, 2021

Thanks @hgt312 @mbrookhart @comaniac . This is now merged.

@hgt312 hgt312 deleted the exprrewriter_anf branch April 12, 2021 08:47
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants