Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYOC][ACL] ACL migrated to v21.02 #7649

Merged
merged 1 commit into from Apr 19, 2021
Merged

[BYOC][ACL] ACL migrated to v21.02 #7649

merged 1 commit into from Apr 19, 2021

Conversation

d-smirnov
Copy link
Contributor

This PR switches ACL* version from v20.11 to v21.02

*ACL stands for Compute Library for the Arm® Architecture.

lhutton1
lhutton1 approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming tests pass CI. Minor point - maybe it would be good to document what versions of ACL are supported, and even add a check in the runtime to ensure a supported version is being used, I don't believe there are any yet?

@d-smirnov
Copy link
Contributor Author

d-smirnov commented Mar 12, 2021 •
edited

For now it was decided to stick only with the latest version of ACL. There are no checks in the runtime

u99127
u99127 suggested changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@u99127 u99127 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you just use the tag instead ? v21.02 would probably be better to use here.

We need to request regeneration of the ci_cpu and ci_arm images.

@d-smirnov
[BYOC][ACL] ACL migrated to v21.02
2e82cdf 
This PR switches ACL* version from v20.11 to v21.02

ACL stands for Compute Library for the Arm® Architecture.

Change-Id: Id364b571d5611ca6eb6d2bde09448a65aae3f73b
@d-smirnov
Copy link
Contributor Author

d-smirnov commented Mar 12, 2021 •
edited

Please could you just use the tag instead ? v21.02 would probably be better to use here.

Amended

We need to request regeneration of the ci_cpu and ci_arm images.

@zhiics, @tqchen, @thierrymoreau Could the ci images be regenerated, please?

u99127
u99127 approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@u99127 u99127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhiics , @tqchen , @tmoreau89 - could you regenerate the ci_cpu and ci_arm docker images ?

@d-smirnov
Copy link
Contributor Author

@zhiics , @tqchen , @tmoreau89
Ping. Could the related ci-images be recreated, please?

@d-smirnov
Copy link
Contributor Author

Ping. @zhiics , @tqchen is there anything we can help to get this patch landed?

@u99127
Copy link
Contributor

u99127 commented Mar 26, 2021

Hi @d-smirnov - looks like we have this request coming through. #7745 which should handle it when things land.

@areusch
Copy link
Contributor

areusch commented Mar 26, 2021

just to clarify--seems like we have two options:

  1. merge Bump ci-cpu and ci-arm container versions #7745 today, then rebuild ci-cpu and ci-arm again and merge a new PR to bump them again
  2. rebuild ci-cpu and ci-arm again and push a new patch to Bump ci-cpu and ci-arm container versions #7745 to bump versions including this patch.

I had built from origin/main when I created ci-cpu and ci-arm for #7745, which didn't have what you want, I believe.

@d-smirnov
Copy link
Contributor Author

@areusch The PR is still relevant. Could we help somehow to let it in?

tmoreau89
tmoreau89 approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmoreau89 tmoreau89 merged commit e67c5b7 into apache:main Apr 19, 2021
@tmoreau89
Copy link
Contributor

@d-smirnov @u99127 @lhutton1 thank you the PR has been merged.

@areusch
Copy link
Contributor

areusch commented Apr 19, 2021

@d-smirnov @u99127 @lhutton1 ok so now we need to do a ci-arm container rebuild, correct?

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 22, 2021
@d-smirnov @mehrdadh
[BYOC][ACL] ACL migrated to v21.02 (apache#7649)
2e7c955 
This PR switches ACL* version from v20.11 to v21.02

ACL stands for Compute Library for the Arm® Architecture.

Change-Id: Id364b571d5611ca6eb6d2bde09448a65aae3f73b
echuraev pushed a commit to echuraev/tvm that referenced this pull request Apr 29, 2021
@d-smirnov @echuraev
[BYOC][ACL] ACL migrated to v21.02 (apache#7649)
69eec1b 
This PR switches ACL* version from v20.11 to v21.02

ACL stands for Compute Library for the Arm® Architecture.

Change-Id: Id364b571d5611ca6eb6d2bde09448a65aae3f73b
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@d-smirnov
[BYOC][ACL] ACL migrated to v21.02 (apache#7649)
820fa07 
This PR switches ACL* version from v20.11 to v21.02

ACL stands for Compute Library for the Arm® Architecture.

Change-Id: Id364b571d5611ca6eb6d2bde09448a65aae3f73b
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@d-smirnov
[BYOC][ACL] ACL migrated to v21.02 (apache#7649)
1251c26 
This PR switches ACL* version from v20.11 to v21.02

ACL stands for Compute Library for the Arm® Architecture.

Change-Id: Id364b571d5611ca6eb6d2bde09448a65aae3f73b
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@d-smirnov
[BYOC][ACL] ACL migrated to v21.02 (apache#7649)
7393405 
This PR switches ACL* version from v20.11 to v21.02

ACL stands for Compute Library for the Arm® Architecture.

Change-Id: Id364b571d5611ca6eb6d2bde09448a65aae3f73b
@u99127
Copy link
Contributor

u99127 commented May 10, 2021

we need a ci_arm and a ci_cpu rebuild.

@leandron
Copy link
Contributor

we need a ci_arm and a ci_cpu rebuild.

This is being tracked in #7995

trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@d-smirnov @trevor-m
[BYOC][ACL] ACL migrated to v21.02 (apache#7649)
e497d7a 
This PR switches ACL* version from v20.11 to v21.02

ACL stands for Compute Library for the Arm® Architecture.

Change-Id: Id364b571d5611ca6eb6d2bde09448a65aae3f73b
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmoreau89 tmoreau89 tmoreau89 approved these changes

@u99127 u99127 u99127 approved these changes

@lhutton1 lhutton1 lhutton1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@d-smirnov @u99127 @areusch @tmoreau89 @leandron @lhutton1