Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Rename TVMContext to Device #7721

Merged
merged 38 commits into from
Mar 26, 2021
Merged

[Refactor] Rename TVMContext to Device #7721

merged 38 commits into from
Mar 26, 2021

Conversation

icemelon
Copy link
Member

@icemelon icemelon commented Mar 22, 2021 •
edited
Loading

This PR implements the RFC https://discuss.tvm.apache.org/t/rfc-rename-tvmcontext-to-tvmdevice/9090

In this PR, we change the TVMContext into Device. The Device is an alias of DLDevice defined in the ndarray.h. In different language bindings, the usage is slightly different

  • In C, directly use DLDevice
  • In C++, use tvm::runtime::Device or tvm::Device
  • In Python, use tvm.runtime.Device
  • In Java, use Device
  • In Rust, use Device
  • In Golang, use Device

@icemelon icemelon requested a review from yzhliu as a code owner March 22, 2021 23:27
@icemelon icemelon changed the title [WIP] Rename TVMContext to Device [Refactor] Rename TVMContext to Device Mar 23, 2021
@tqchen tqchen added status: need review status: need update need update based on feedbacks labels Mar 23, 2021
@tqchen
Copy link
Member

tqchen commented Mar 23, 2021

@icemelon9 please rebase against the main

@tqchen tqchen self-assigned this Mar 23, 2021
@icemelon icemelon force-pushed the ctx2dev branch 4 times, most recently from c78dd40 to af2c0fb Compare March 25, 2021 06:49
@tqchen tqchen merged commit fbfeee4 into apache:main Mar 26, 2021
@tqchen
Copy link
Member

tqchen commented Mar 26, 2021

Thanks @icemelon9 this PR is now merged!

@tqchen tqchen added status: accepted and removed status: need review status: need update need update based on feedbacks labels Mar 26, 2021
PhilippvK added a commit to tum-ei-eda/utvm_staticrt_codegen that referenced this pull request Apr 14, 2021
@PhilippvK
Fix: Rename DLContext to DLDevice
b1a8e90 
See latest changes in TVM and ?:
- apache/tvm#7721
- https://discuss.tvm.apache.org/t/rfc-rename-tvmcontext-to-tvmdevice/9090
- dmlc/dlpack@8323706#diff-1564e5abd0da5cf46e82b28b0058996df944007494520a2b0a6b629880eaa097
PhilippvK added a commit to tum-ei-eda/utvm_staticrt_codegen that referenced this pull request Apr 14, 2021
@PhilippvK
Fix: Rename DLContext to DLDevice
1a3068f 
See latest changes in TVM and dlpack:
- apache/tvm#7721
- https://discuss.tvm.apache.org/t/rfc-rename-tvmcontext-to-tvmdevice/9090
- dmlc/dlpack@8323706#diff-1564e5abd0da5cf46e82b28b0058996df944007494520a2b0a6b629880eaa097
@PhilippvK PhilippvK mentioned this pull request Apr 14, 2021
Merged
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@icemelon
[Refactor] Rename TVMContext to Device (apache#7721)
44e87e1
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@icemelon @trevor-m
[Refactor] Rename TVMContext to Device (apache#7721)
528a21f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

@yzhliu yzhliu Awaiting requested review from yzhliu

Assignees

@tqchen tqchen

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icemelon @tqchen