[Relay][Pass] Update SimplifyTranspose to correctly simplify rank changing layout transforms #7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
reviewed
Apr 7, 2021
ANSHUMAN87
reviewed
Apr 8, 2021
There was a problem hiding this comment.
Thanks @csullivan for the PR!
Please find some comments.
Overall LGTM!
|
Thanks @comaniac @ANSHUMAN87! I've extended the support for various rank changing layout transform + transpose patterns. Please see the additional tests for an overview and let me know other change requests you may have. |
ANSHUMAN87
reviewed
Apr 21, 2021
ANSHUMAN87
reviewed
Apr 21, 2021
comaniac
approved these changes
Apr 21, 2021
|
@csullivan Thanks for the contribution. What's the status on this? I looks like it has a lint error. |
when layout transformation changes rank.
|
Thanks @csullivan @ANSHUMAN87 |
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
…nging layout transforms (apache#7807)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…nging layout transforms (apache#7807)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…nging layout transforms (apache#7807)
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…nging layout transforms (apache#7807)
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…nging layout transforms (apache#7807)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to SimplifyTranspose to simplify consecutive transpose<->layout_transform operations when the layout transform involves a rank expansion or contraction. The added unit test fails on main because the current SimplifyTranspose only doesn't consider the case when the layout transform and transpose may act on tensors of different rank. As an example,
NCHW4c -> LayoutTransform -> NCHW -> Transpose -> NHWCnow simplifies to
NCHW4c -> LayoutTransform -> NHWC.The reverse, rank expansion, is also supported.