[FIX] Fix howto_deploy #7841
Merged
[FIX] Fix howto_deploy #7841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were missing files in tvm_runtime_pack.cc
This was referenced Apr 13, 2021
yzh119
reviewed
Apr 14, 2021
| @@ -37,7 +37,9 @@ | |||
| * You need to remember to change it to point to the right file. | |||
| * | |||
| */ | |||
| #define TVM_USE_LIBBACKTRACE 0 | |||
There was a problem hiding this comment.
Is it necessary to disable libbacktrace?
There was a problem hiding this comment.
yes, because we aren't linking to libbacktrace.
tqchen
approved these changes
Apr 14, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
We were missing files in tvm_runtime_pack.cc
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
We were missing files in tvm_runtime_pack.cc
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
We were missing files in tvm_runtime_pack.cc
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
We were missing files in tvm_runtime_pack.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing files in tvm_runtime_pack.cc.
Manually packing the runtime files has led to many issues when adding new features. We should probably figure out a better way to do it.
@tqchen