[BugFix] Print doubles with precision 17 in SaveJSON and TVM script printer #7846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing the subtle issue! BTW, would you like to also fix the TVM script printer? |
|
Okay, I'm gonna to take a look soon. |
MasterJH5574
changed the title
|
@junrushao1994 I've fixed the TVM script printer. Would you like to take another look? Thanks! |
junrushao
approved these changes
Apr 14, 2021
|
Thanks @Hzfengsy @junrushao1994 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…rinter (apache#7846) * [BugFix] SaveJSON type double with precision 17 * [BugFix] Fix for TVM script printer
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…rinter (apache#7846) * [BugFix] SaveJSON type double with precision 17 * [BugFix] Fix for TVM script printer
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…rinter (apache#7846) * [BugFix] SaveJSON type double with precision 17 * [BugFix] Fix for TVM script printer
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…rinter (apache#7846) * [BugFix] SaveJSON type double with precision 17 * [BugFix] Fix for TVM script printer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in SaveLoad, which didn't save enough digits for double value and may cause precision loss when loading the value from JSON again. Besides, this PR adds a regression test for the precision loss case.
Before this PR, double value is saved with precision 16. However, actually we should save at least 17 digits to avoid precision loss, according to IEEE 754-1985 standard:
Reference
cc @tqchen @junrushao1994