[Hotfix] Typo in Vulkan runtime change causing severe perf regression for dGPU #7871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that #7833 introduced severe perf regression for vk + dGPU. Running
cuda_gemm_square.py
on R9 nano, I found that vk result is extremely slow:After bisecting, I found that I had a typo in #7833 resulting in using a wrong memory type for device buffers 🤦♂️ Interestingly, there is no regression for APU, so I didn't notice during development. Now this has been fixed and vk performance is great as before:
cc @tqchen