Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Docker] set environment variables for UTF-8, to prevent errors when running black #8089

Merged
merged 1 commit into from May 21, 2021
Merged

[CI][Docker] set environment variables for UTF-8, to prevent errors when running black #8089

merged 1 commit into from May 21, 2021

Conversation

leandron
Copy link
Contributor

Updates ci_lint image to use UTF-8 encoding.

  • Sets environment shell encoding to UTF-8

  • This prevents the black formatting tool to exit with the following error:
    "RuntimeError: Click will abort further execution because Python was
    configured to use ASCII as encoding for the environment"

…hen running `black`

 * Sets environment shell encoding to UTF-8

 * This prevents the black formatting tool to exit with the following error:
   "RuntimeError: Click will abort further execution because Python was
    configured to use ASCII as encoding for the environment"
@leandron
Copy link
Contributor Author

That's just a problem not seen yet, before we implement our image rebuilds.

cc @tqchen @areusch for reviews.

@leandron
Copy link
Contributor Author

@areusch if you have a minute, can you review?

@areusch
Copy link
Contributor

areusch commented May 20, 2021

@leandron if it's ok, i'd like to hold this change until we finish #7995. i think it's likely not going to affect it, but we have a few CUDA changes to make in order to make any progress on updating the images and i'd like to not mix future changes. that said, if it's pressing, i don't think this one will affect much.

@leandron
Copy link
Contributor Author

@leandron if it's ok, i'd like to hold this change until we finish #7995. i think it's likely not going to affect it, but we have a few CUDA changes to make in order to make any progress on updating the images and i'd like to not mix future changes. that said, if it's pressing, i don't think this one will affect much.

It would be good to merge as it is very low impact - if possible, so that I can keep validating the images overnight.

In case you want to keep this to organise #7995 - I also support it -, I’ll manage with some local change on my CI jobs. Let me know.

@areusch
Copy link
Contributor

areusch commented May 20, 2021

@tkonolige wdyt? i'm holding most changes, but this one a) only affects ci-lint and b) is pretty low-impact

@tkonolige
Copy link
Contributor

This should be an easy rebuild. Let's merge.

@areusch areusch merged commit aba2806 into apache:main May 21, 2021
@leandron leandron deleted the ci_lint_encoding branch June 4, 2021 09:17
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
…hen running `black` (apache#8089)

* Sets environment shell encoding to UTF-8

 * This prevents the black formatting tool to exit with the following error:
   "RuntimeError: Click will abort further execution because Python was
    configured to use ASCII as encoding for the environment"
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
…hen running `black` (apache#8089)

* Sets environment shell encoding to UTF-8

 * This prevents the black formatting tool to exit with the following error:
   "RuntimeError: Click will abort further execution because Python was
    configured to use ASCII as encoding for the environment"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants