[microTVM] Add wait to QEMU Setup #8236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areusch
requested changes
Jun 10, 2021
areusch
requested changes
Jun 10, 2021
areusch
requested changes
Jun 10, 2021
mehrdadh
force-pushed
the
qemu_make_wait
branch
2 times, most recently
from
1d9b45a
to
ae31405
Compare
areusch
requested changes
Jun 11, 2021
areusch
approved these changes
Jun 15, 2021
|
thanks @mehrdadh ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* add wait * address comments * address comments * test added * add suggestions * fadd message assert for test
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* add wait * address comments * address comments * test added * add suggestions * fadd message assert for test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases where the Zephyr project would rebuild itself, qemu would setup and wait for message from the microtvm target, however the microtvm target is not ready yet since these are happening in different processes. In this PR we add a wait to qemu to make sure they happen synchronously.
cc @areusch