Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorFlow][Frontend] Adding InversePermutation Op #8277

Merged
merged 7 commits into from
Jun 21, 2021

Conversation

cailun01
Copy link
Contributor

Computes the inverse permutation of a tensor. This Op is used by Mask R-CNN
or other object detection models.

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

tvm.testing.assert_allclose(tf_output[i], tvm_output[i], atol=1e-4, rtol=1e-5)

sess.close()
# @tvm.testing.parametrize_targets("llvm", "cuda")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test commented out intentionally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to uncomment that line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've just noticed that I forgot to uncomment the whole test_read_variable_op.

python/tvm/topi/transform.py Outdated Show resolved Hide resolved
@leandron
Copy link
Contributor

Hi @cailun01, there are some minor linting issues with your change. Have a look on the documentation at https://tvm.apache.org/docs/contribute/pull_request.html#submit-a-pull-request to see instructions on how to run the linter on your own machine.

@cailun01
Copy link
Contributor Author

Hi @cailun01, there are some minor linting issues with your change. Have a look on the documentation at https://tvm.apache.org/docs/contribute/pull_request.html#submit-a-pull-request to see instructions on how to run the linter on your own machine.

OK, Thanks!

Computes the inverse permutation of a tensor. This Op is used by Mask R-CNN
or other object detection models.
@masahi masahi merged commit 13146be into apache:main Jun 21, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* [TensorFlow][Frontend] Adding InversePermutation Op

Computes the inverse permutation of a tensor. This Op is used by Mask R-CNN
or other object detection models.

* uncomment test_read_variable_op

* restore several tests

* fix lint error

* fix python linting error

* fix lint error

* restore mistakenly deleted codes
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
* [TensorFlow][Frontend] Adding InversePermutation Op

Computes the inverse permutation of a tensor. This Op is used by Mask R-CNN
or other object detection models.

* uncomment test_read_variable_op

* restore several tests

* fix lint error

* fix python linting error

* fix lint error

* restore mistakenly deleted codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants