[Relay to Onnx][LRN] #8323
Merged
[Relay to Onnx][LRN] #8323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schilkunda-amba
commented
Jun 24, 2021
schilkunda-amba
commented
- Added support for LRN operator in relay to onnx conversion
- Added unit test
* Added unit test case for LRN
* change single quotes to double * set space to 4 instead of 2
trevor-m
requested changes
Jun 24, 2021
python/tvm/contrib/target/onnx.py
Outdated
| "beta": attrs.beta, | ||
| "bias": attrs.bias, | ||
| "size": attrs.size | ||
| # axis? |
There was a problem hiding this comment.
Remove comment.
It looks like the ONNX LRN op doesn't have an axis parameter, as it always applies to axis 1.
We should probably add assert somewhere to check that the axis is also 1 in the Relay operator that is being converted.
There was a problem hiding this comment.
Have added the axis check.
* Assert if axis != 1
trevor-m
approved these changes
Jun 25, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Added support for LRN operator * [Relay to Onnx] * Added unit test case for LRN * * reformatted * * reformatted (2) * * fixed formatting issues in relay to onnx conversion script * * fixed formatting * change single quotes to double * set space to 4 instead of 2 * * reformatted onnx.py: corrected spaces * [Relay to Onnx] LRN * Assert if axis != 1 * * fixed formatting Co-authored-by: zxy844288792 <zhoxingy@amazon.com>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* Added support for LRN operator * [Relay to Onnx] * Added unit test case for LRN * * reformatted * * reformatted (2) * * fixed formatting issues in relay to onnx conversion script * * fixed formatting * change single quotes to double * set space to 4 instead of 2 * * reformatted onnx.py: corrected spaces * [Relay to Onnx] LRN * Assert if axis != 1 * * fixed formatting Co-authored-by: zxy844288792 <zhoxingy@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.