Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][TOPI] Resize 1D #8346

Merged
merged 12 commits into from
Jul 5, 2021
Merged

[Relay][TOPI] Resize 1D #8346

merged 12 commits into from
Jul 5, 2021

Conversation

mbrookhart
Copy link
Contributor

@mbrookhart mbrookhart commented Jun 25, 2021

This PR introduces a Resize1D op and refactors Resize2D and Resize3D so that all three follow the same API and implementation strategy. It also unifies the reference kernels for testing and expands the capabilities of the reference kernels.

cc @jwfromm @masahi

@mbrookhart mbrookhart force-pushed the resize_1d branch 3 times, most recently from 8da75d9 to 7ffbe7b Compare July 1, 2021 14:23
@mbrookhart mbrookhart changed the title [DRAFT][Relay][TOPI] Resize 1D [Relay][TOPI] Resize 1D Jul 2, 2021
@mbrookhart
Copy link
Contributor Author

@masahi @jwfromm I think this is finally ready for review. Sorry for dumping such a large PR on you on a Friday :( Totally fine if you don't get to it for a while.

@masahi masahi merged commit d3fc562 into apache:main Jul 5, 2021
@masahi
Copy link
Member

masahi commented Jul 5, 2021

Thanks @mbrookhart

ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* rename resize to resize2d

* refactor resize_2d

* Add resize1d op, normalize attribute names across ops

* normalize resize3d to match the API of 1D and 2D

* fix lint

* fix relay tests from API change

* refactor topi tests, docs

* fix method naming in framework frontends

fix more frontend issues

* refactor resize tests to reuse components, add more coordinate tranform modes to tests

* add cubic resize reference kernel and tests, add relay tests for resize1d

* fix pylint

* fix test typo
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
* rename resize to resize2d

* refactor resize_2d

* Add resize1d op, normalize attribute names across ops

* normalize resize3d to match the API of 1D and 2D

* fix lint

* fix relay tests from API change

* refactor topi tests, docs

* fix method naming in framework frontends

fix more frontend issues

* refactor resize tests to reuse components, add more coordinate tranform modes to tests

* add cubic resize reference kernel and tests, add relay tests for resize1d

* fix pylint

* fix test typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants