[FIX] Detect like cores by looking at scaling_max_freq instead of cpuinfo_max_freq #8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuinfo_max_freq
|
Yes. I agree PyTorch CPUInfo library is one good alternative. However, we will introduce one dependency and we should handle it carefully for cross compilation (because we are in the runtime component). |
tqchen
approved these changes
Jun 30, 2021
lygztq
pushed a commit
to lygztq/tvm
that referenced
this pull request
Jul 1, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my AMD 3950X,
/sys/devices/systen/cpu/cpu*/cpufreq/cpuinfo_max_freqis not the same across all cores. If I look atscaling_max_freqinstead, then I see that all cores are the same frequency (as expected). This probably still won't work correctly across all platforms, but I don't think there is an easier, quick way to do the detection. Maybe we should think about using pytorch's cpuinfo library (https://github.com/pytorch/cpuinfo).@tqchen @FrozenGene