Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCKER] fix keras install #8391

Merged
merged 1 commit into from Jul 2, 2021
Merged

Conversation

mbrookhart
Copy link
Contributor

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (mention to #8339, to keep track of what is being done)

@mbrookhart mbrookhart merged commit 22204be into apache:main Jul 2, 2021
@Lunderberg
Copy link
Contributor

Though it doesn't seem to be an issue right now, I think we don't need to have the pin on the h5py version, just keras. The previous time it was pinned, there was a comment with a tensorflow issue. With the upgrade to tensorflow 2.4.x, the pinned h5py shouldn't be necessary anymore.

# h5py is pinned to minor than 3 due to issues with tensorflow: https://github.com/tensorflow/tensorflow/issues/44467

That said, testing new docker versions with fewer moving parts/upgraded versions may also make sense.

ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants