Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix x86 dense schedule extern ops #8420

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Conversation

comaniac
Copy link
Contributor

@comaniac comaniac commented Jul 7, 2021

Fix a bug introduced by #8234 that does not use generic.schedule_extern to cBLAS and MKLDNN dense ops. This results in the following error when lowering those ops:

AttributeError: ExternOp object has no attributed axis

cc @jcf94

@comaniac comaniac requested a review from jcf94 July 7, 2021 20:53
Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks that's my fault. I find that the schedule of matmul has a same problem.

Let's also update all those schedule_matmul_xxx in this file to generic.schedule_extern.

@comaniac
Copy link
Contributor Author

comaniac commented Jul 8, 2021

cc @kevinthesun @icemelon9. I found that the schedule for MKL is introduced in #7404, but it seems not working for me. Please also take a look.

@jcf94 jcf94 merged commit 4b67e9d into apache:main Jul 9, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* [Bug] Fix x86 dense schedule extern ops

* more

* lint
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
* [Bug] Fix x86 dense schedule extern ops

* more

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants