Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize CodeOwners File #8512

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Organize CodeOwners File #8512

merged 1 commit into from
Jul 21, 2021

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Jul 20, 2021 •
edited
Loading

  • Order is important; the last matching pattern takes the most precedence.
  • Explicit list all the prefix so the pattern matches the folder prefix patterns

@tqchen tqchen requested a review from a team as a code owner July 20, 2021 13:29
@tqchen tqchen changed the title Make codeowner always matches prefix Make codeowner always start with concrete prefix Jul 20, 2021
@tqchen
Organize the CodeOwners file:
9801a30 
- Order by depth first
- Always show the complete prefix
@tqchen tqchen changed the title Make codeowner always start with concrete prefix Organize CodeOwners File Jul 20, 2021
jcf94
jcf94 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

icemelon
icemelon approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahi
Copy link
Member

masahi commented Jul 21, 2021

@tqchen Need to push again

@tqchen tqchen merged commit 78142b6 into apache:main Jul 21, 2021
@Mousius Mousius mentioned this pull request Sep 26, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@tqchen @ylc
Organize the CodeOwners file: (apache#8512)
1ac630d 
- Order by depth first
- Always show the complete prefix
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@tqchen @ylc
Organize the CodeOwners file: (apache#8512)
93ede50 
- Order by depth first
- Always show the complete prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areusch areusch areusch approved these changes

@icemelon icemelon icemelon approved these changes

@jcf94 jcf94 jcf94 approved these changes

@junrushao junrushao junrushao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tqchen @masahi @areusch @icemelon @jcf94 @junrushao