[RPC] Add explicit type cast to print. #8524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
requested review from
comaniac,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
|
@michalpiszczek can you take a look at this PR? |
tqchen
approved these changes
Jul 21, 2021
|
Thanks @jwfromm, LGTM! We should address the root issue of missing IPs in a follow up once we figure out why that's happening |
jroesch
approved these changes
Jul 22, 2021
added 2 commits
July 23, 2021 01:25
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little one liner adds a string cast to a print statement in the RPC query code. Occasionally there isn't an IP address reported by the RPC causing the string concatenate to fail due to a Nonetype. Adding a cast avoids the error and is good form in general.