[FFI] Specifically check handle for recursion during shutdown #8548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: previously slot may get overriden by child class and it is better to directly check for handle here.
tqchen
requested review from
areusch,
junrushao,
kazum,
liangfu,
masahi,
tmoreau89,
vinx13 and
ZihengJiang
as code owners
|
Thanks for the PR! Does it finally resolve the infinite recursion issue when an exception is thrown in the constructor? |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…#8548) NOTE: previously slot may get overriden by child class and it is better to directly check for handle here.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…#8548) NOTE: previously slot may get overriden by child class and it is better to directly check for handle here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: previously slot may get overriden by child class and it
is better to directly check for handle here.
Can resolve some flaky error for long throw in CI