Add a --context-path for build.sh
#8557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
requested changes
Jul 26, 2021
Mousius
approved these changes
Jul 26, 2021
mehrdadh
approved these changes
Jul 26, 2021
|
@leandron LGTM. Thanks for this change! |
|
just curious what's the use case for this change? |
We have some tooling that will use Dockerfiles out of tree (in a temp directory), but it needs to keep the context pointing to the tree, in order to resolve relative paths. |
in different directories, and still get relative paths to work. * Add new option --context-path to build.sh * Keeps the default as the `dirname` of the Dockerfile, so no changes expected in the current behaviour
|
It seems CI is happy now, can I get a review and a merge if you're happy? @areusch |
areusch
approved these changes
Jul 27, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…ache#8557) in different directories, and still get relative paths to work. * Add new option --context-path to build.sh * Keeps the default as the `dirname` of the Dockerfile, so no changes expected in the current behaviour
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ache#8557) in different directories, and still get relative paths to work. * Add new option --context-path to build.sh * Keeps the default as the `dirname` of the Dockerfile, so no changes expected in the current behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
--context-pathfor build.sh, allowing to test Dockerfiles in different directories, and still get relative paths to work.dirnameof the Dockerfile, sono changes expected in the current behaviour
cc @Mousius @areusch @mehrdadh for reviews