[AutoScheduler] Fix FLOPS estimation #8695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
requested review from
areusch,
jcf94,
jroesch,
junrushao,
merrymercy,
tqchen,
vinx13 and
yzhliu
as code owners
jcf94
approved these changes
Aug 10, 2021
junrushao
approved these changes
Aug 10, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Aug 11, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AutoScheduler FLOP estimator now mis-estimates the following case to be 0 FLOPS:
This is because the expression
A[i] > 0has output dtypeuintwhile the input dtypes arefloat32. In this case the current FLOP estimater ignores the comparison flops. The original concern behinds this logic is to avoid counting index calculation, but we need to make it more general to cover the above case.cc @merrymercy