-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][VitisAI] Update CI Vitis AI PyXIR version to v0.3.1 #8814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@areusch IIUC, we could now directly merge the image-related PRs and the image will be re-built nightly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @jtuyls !
Yes, the images are rebuilt daily, but not updated in CI automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does gen_requirements.py
also needs to be updated with the correct version for vitis-ai (pyxir) dependency?
@leandron I can add the dependencies to the
And is there anything else that needs to happen for this? |
Hey @jtuyls, sorry it took me a bit of time to reply. Yes, there is also the "constraints", in case you want to specify versions: tvm/python/gen_requirements.py Lines 204 to 206 in 8326edd
Apart from that, your snippet above looks ok. |
@leandron I added the dependencies to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we just need to make sure that everywhere we use things that depend on pyxir, we lazy load and show and appropriate error message. Happy to merge this PR once it passes CI.
* Update CI Vitis AI PyXIR version to v0.3.1 * Add Vitis AI requirements to gen_requirements.py
* Update CI Vitis AI PyXIR version to v0.3.1 * Add Vitis AI requirements to gen_requirements.py
This PR updates the CI Vitis AI PyXIR version to v0.3.1. This is needed for testing a subsequent PR that updates the Vitis AI docker and documentation to Vitis AI 1.4. The ReLU test is removed as it fails with the updated PyXIR version and will be added back in the other PR.
@comaniac @leandron @zhiics