Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][VitisAI] Update CI Vitis AI PyXIR version to v0.3.1 #8814

Merged
merged 2 commits into from
Sep 11, 2021

Conversation

jtuyls
Copy link
Contributor

@jtuyls jtuyls commented Aug 23, 2021

This PR updates the CI Vitis AI PyXIR version to v0.3.1. This is needed for testing a subsequent PR that updates the Vitis AI docker and documentation to Vitis AI 1.4. The ReLU test is removed as it fails with the updated PyXIR version and will be added back in the other PR.
@comaniac @leandron @zhiics

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@areusch IIUC, we could now directly merge the image-related PRs and the image will be re-built nightly?

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jtuyls !

@tmoreau89
Copy link
Contributor

@comaniac @areusch is on PTO, I'll CC @leandron who can answer your question

@leandron
Copy link
Contributor

Yes, the images are rebuilt daily, but not updated in CI automatically.

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does gen_requirements.py also needs to be updated with the correct version for vitis-ai (pyxir) dependency?

@jtuyls
Copy link
Contributor Author

jtuyls commented Aug 27, 2021

@leandron I can add the dependencies to the gen_requirements.py. I am not familiar with how it's set up but I guess it would look like this?

(
        "vitis-ai",
        (
            "Requirements for the Vitis AI integration",
            [
                "pyxir", 
                "h5py",
                "progressbar",
            ],
        ),
),

And is there anything else that needs to happen for this?

@leandron
Copy link
Contributor

leandron commented Sep 3, 2021

@leandron I can add the dependencies to the gen_requirements.py. I am not familiar with how it's set up but I guess it would look like this?

(
        "vitis-ai",
        (
            "Requirements for the Vitis AI integration",
            [
                "pyxir", 
                "h5py",
                "progressbar",
            ],
        ),
),

And is there anything else that needs to happen for this?

Hey @jtuyls, sorry it took me a bit of time to reply.

Yes, there is also the "constraints", in case you want to specify versions:

CONSTRAINTS = [
("astroid", None),
("attrs", None),

Apart from that, your snippet above looks ok.

@jtuyls jtuyls requested a review from zhiics as a code owner September 8, 2021 10:34
@jtuyls
Copy link
Contributor Author

jtuyls commented Sep 8, 2021

@leandron I added the dependencies to gen_requirements.py. I didn't add pyxir as it isn't pip installable.

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to make sure that everywhere we use things that depend on pyxir, we lazy load and show and appropriate error message. Happy to merge this PR once it passes CI.

@masahi masahi merged commit 8b59f99 into apache:main Sep 11, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* Update CI Vitis AI PyXIR version to v0.3.1

* Add Vitis AI requirements to gen_requirements.py
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* Update CI Vitis AI PyXIR version to v0.3.1

* Add Vitis AI requirements to gen_requirements.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants