-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROFILING] Profiling over RPC #8885
Conversation
432f044
to
ba49bb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicks but otherwise LGTM.
self.module = _ffi_api._VirtualMachineDebug(exe.module) | ||
|
||
# Make sure the constructor of the VM module is on the proper device | ||
if device.device_type >= rpc_base.RPC_SESS_MASK: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking device type using a >=
is kind of confusing. If there isn't a better way to check can you explain why the >=
works in a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
while (reader.NextArrayItem()) { | ||
calls.push_back(parse_metrics(&reader)); | ||
} | ||
// reader.EndArray(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these commented out lines be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like leaving these lines in as it makes it clear where the end of each Array/Object is.
* [PROFILING] Profiling over RPC Allow for profiling over RPC by serializing the returned report before sending it. Also remove collectors argument when profiling over rpc because it cannot be serialized. * lint * fixes * add comments
* [PROFILING] Profiling over RPC Allow for profiling over RPC by serializing the returned report before sending it. Also remove collectors argument when profiling over rpc because it cannot be serialized. * lint * fixes * add comments
Allow for profiling over RPC by serializing the returned report beforesending it. Also remove collectors argument when profiling over rpc because it cannot be serialized.
@jwfromm @leandron