Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manupa-arm to CODEOWNERS #8911

Merged
merged 1 commit into from Sep 7, 2021
Merged

Add manupa-arm to CODEOWNERS #8911

merged 1 commit into from Sep 7, 2021

Conversation

areusch
Copy link
Contributor

@areusch areusch commented Sep 2, 2021

Adding Manupa to various CODEOWNERS based on the areas being contributed.

cc @tqchen @manupa-arm

@manupa-arm let me know if this seems reasonable or if you want to be added to more or less locations.

@areusch areusch requested a review from a team as a code owner September 2, 2021 17:16
leandron
leandron approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just need to be re-triggered as it is facing the flaky test in CI issue.

@manupak
Copy link
Contributor

manupak commented Sep 3, 2021 •
edited

Thanks all!

@areusch @jroesch
The locations seems fine.
I was wondering whether it ll be useful for me to track changes in src/relay/backend/ (there is not a one yet) related to executor codegen changes and future refactoring of the lowering pipeline.

I assume this is the file being used to do automatic requests for reviews by GH?

@areusch
Copy link
Contributor Author

areusch commented Sep 7, 2021

@manupa-arm yep, this is that file. it will start spamming you quite a bit now :)

I went to go and add that line but I realized we should add a few others as well. let's create a separate PR for that.

@manupak
Copy link
Contributor

manupak commented Sep 7, 2021

Ack, make sense @areusch

@masahi masahi merged commit 4f1d6ab into apache:main Sep 7, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@areusch @ylc
Add manupa-arm to CODEOWNERS (apache#8911)
9701ec5
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@areusch @ylc
Add manupa-arm to CODEOWNERS (apache#8911)
5ea38b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandron leandron leandron approved these changes

@junrushao junrushao junrushao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@areusch @manupak @leandron @junrushao @masahi