New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect AOT Memory Planning #8926
Conversation
CC @manupa-arm |
Also CC @mbs-octoml @electriclilies for reviews 馃樃 |
4fbb9f5
to
cc0c43b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM! I'd like to see CalculateWorkspaceBytes in a pass in the future instead of being run directly in the exectutor, but this is fine for now
aea2a68
to
97401c5
Compare
This change introduces a second memory planning phase in the AOT code generator once the storage rewrite pass has been completed, fixing incorrectly sized workspaces for a variety of models. It comes with accompanying tests so we can safely refactor this later. Also corrected a typo in the TE compiler regards the memory alignment argument 馃樃 Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com>
97401c5
to
fdedfed
Compare
@Mousius is it possible for you guys to put this as a backlog item? will land this version but in general better to try and split these things into passes so we can make the executor code gens function more uniform instead of each one having different arguments/return values, etc. |
This change introduces a second memory planning phase in the AOT code generator once the storage rewrite pass has been completed, fixing incorrectly sized workspaces for a variety of models. It comes with accompanying tests so we can safely refactor this later. Also corrected a typo in the TE compiler regards the memory alignment argument 馃樃 Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com> Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com>
This change introduces a second memory planning phase in the AOT code generator once the storage rewrite pass has been completed, fixing incorrectly sized workspaces for a variety of models. It comes with accompanying tests so we can safely refactor this later. Also corrected a typo in the TE compiler regards the memory alignment argument 馃樃 Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com> Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com>
This change introduces a second memory planning phase in the AOT code
generator once the storage rewrite pass has been completed, fixing
incorrectly sized workspaces for a variety of models.
It comes with accompanying tests so we can safely refactor this later.
Also corrected a typo in the TE compiler regards the memory alignment
argument 馃樃
Co-authored-by: Manupa Karunaratne Manupa.Karunaratne@arm.com