Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM] Temporarily remove mps2_an521 from CI #8927

Merged
merged 1 commit into from Sep 4, 2021

Conversation

gromero
Copy link
Contributor

@gromero gromero commented Sep 3, 2021

Mark test_rpc_large_array to xfail when mps2_an521 is selected as the
test platform due to issue 8728. That issue is failing quite often on
CI environment.

Signed-off-by: Gustavo Romero gustavo.romero@linaro.org

@gromero
Copy link
Contributor Author

gromero commented Sep 3, 2021

@areusch @leandron @mehrdadh Hi guys, could I get reviews for that change please? I need more time to fix #8728 and as you know it's causing too much trouble on the CI. Thanks!

Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right thing to do for the moment, thanks for raising this @gromero - CC @manupa-arm

@gromero
Copy link
Contributor Author

gromero commented Sep 3, 2021

I think this is the right thing to do for the moment, thanks for raising this @gromero - CC @manupa-arm

Thanks for the review @Mousius 👍

@manupak
Copy link
Contributor

manupak commented Sep 3, 2021

Thanks for this! I agree to make it xfail until we know better.

@gromero
Copy link
Contributor Author

gromero commented Sep 3, 2021

@manupa-arm @areusch @Mousius The CI failed on a different test now, but I was in fact curious if CI would complain about another test, so that was unexpected expected to me. It only confirms the issue doesn't really affect a single test, but possible all of them. I'll xfail everything for mps2_an521 remove the board from the CI. I believe it's the safest thing to do now.

Temporarily removing the mps2_an512 board from CI due to issue 8728.
Possibly all tests can fail on mps2_an512, so removing the board
instead of xfailing specific tests.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, this is unfortunate @gromero - I agree with removing the offending platform 👍

@Mousius
Copy link
Member

Mousius commented Sep 3, 2021

@gromero could you update the PR title? 😸

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gromero this seems reasonable while we debug further

@gromero gromero changed the title [microTVM] Mark test_rpc_large_array to xfail on mps2_an521 [microTVM] Temporarily remove mps2_an521 from CI Sep 3, 2021
@gromero
Copy link
Contributor Author

gromero commented Sep 3, 2021

@gromero could you update the PR title?

Sure. Done (I'm wondering if github uses the PR's title when squashing the final commit that lands. I always get confused about it and always rely on what I see in git :) )

@gromero
Copy link
Contributor Author

gromero commented Sep 3, 2021

Thanks @gromero this seems reasonable while we debug further

@areusch Thanks for the review! Yeah, I'll continue to investigate it as time allows.

@masahi masahi merged commit f0137fb into apache:main Sep 4, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
Temporarily removing the mps2_an512 board from CI due to issue 8728.
Possibly all tests can fail on mps2_an512, so removing the board
instead of xfailing specific tests.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Temporarily removing the mps2_an512 board from CI due to issue 8728.
Possibly all tests can fail on mps2_an512, so removing the board
instead of xfailing specific tests.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants