[AutoScheduler] Fix custom build func in PopenWorker #8939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
requested review from
comaniac,
Hzfengsy,
jcf94,
junrushao and
merrymercy
as code owners
vinx13
force-pushed
the
fix/auto_scheduler_custom_build
branch
2 times, most recently
from
6d00683
to
96f43c2
Compare
vinx13
force-pushed
the
fix/auto_scheduler_custom_build
branch
from
96f43c2
to
0f02b3d
Compare
shingjan
reviewed
Sep 8, 2021
| @@ -701,7 +700,7 @@ def local_builder_build(inputs, timeout, n_parallel, build_func="default", verbo | |||
| [ | |||
| ( | |||
| i.serialize(), | |||
| build_func, | |||
| BuildFunc.build_func, | |||
There was a problem hiding this comment.
If we are passing the callable function here, should we also change the type of this argument from str to callable at line 655?
There was a problem hiding this comment.
Good catch, could you send a PR?
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [AutoScheduler] Fix custom build func in PopenWorker * Add assertion
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [AutoScheduler] Fix custom build func in PopenWorker * Add assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue introduced in #8492