[microTVM] Zephyr: implement 'west_cmd' server option #8941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gromero
requested review from
comaniac,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
areusch
reviewed
Sep 8, 2021
| @@ -451,6 +451,11 @@ def flash(self, options): | |||
| recover_args.extend(_get_nrf_device_args(options)) | |||
| check_call(recover_args, cwd=API_SERVER_DIR / "build") | |||
|
|
|||
| if "west_cmd" in options: | |||
| west_cmd = options["west_cmd"] | |||
| cmake_args = ["cmake", "..", f"-DWEST={west_cmd}"] | |||
There was a problem hiding this comment.
i wonder if we should add this option to the original cmake invocation on line 395? i think it makes sense to have west_cmd, but thinking it's better to place there just in case this triggers a rebuild.
Currently Zephyr Project API server lists option 'west_cmd' as an option available in Zephyr platform by advertising it in PROJECT_OPTIONS but that option is not used by any API method. That commit adds that option to the server as a non-required option to the build() interface method, allowing the user to specify an alternative path to the west tool. If that option is not specified the Zephyr build system takes care of searching for west as a module (so relying on West being available on Python, i.e. relying on 'python3 -m west'). Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
gromero
force-pushed
the
implement-zephyr-west-cmd-option
branch
from
4bd1c0d
to
395bcbe
Compare
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
Currently Zephyr Project API server lists option 'west_cmd' as an option available in Zephyr platform by advertising it in PROJECT_OPTIONS but that option is not used by any API method. That commit adds that option to the server as a non-required option to the build() interface method, allowing the user to specify an alternative path to the west tool. If that option is not specified the Zephyr build system takes care of searching for west as a module (so relying on West being available on Python, i.e. relying on 'python3 -m west'). Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Currently Zephyr Project API server lists option 'west_cmd' as an option available in Zephyr platform by advertising it in PROJECT_OPTIONS but that option is not used by any API method. That commit adds that option to the server as a non-required option to the build() interface method, allowing the user to specify an alternative path to the west tool. If that option is not specified the Zephyr build system takes care of searching for west as a module (so relying on West being available on Python, i.e. relying on 'python3 -m west'). Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Zephyr Project API server lists option 'west_cmd' as an
option available in Zephyr platform by advertising it in PROJECT_OPTIONS
but that option is not used by any API method.
That commit adds that option to the server as a non-required option to
the flash() interface method, allowing the user to specify an
alternative path to the west tool. If that option is not specified the
Zephyr build system takes care of searching for west as a module (so
relying on West being available on Python, i.e. relying on
'python3 -m west').
Signed-off-by: Gustavo Romero gustavo.romero@linaro.org